From: Eric Anholt Subject: Re: [PATCH] [RFC] drm/i915: read-read semaphore optimization Date: Tue, 13 Dec 2011 09:22:01 -0800 Message-ID: <87fwgoidza.fsf@eliezer.anholt.net> References: <1323748328-10153-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1607571429==" Return-path: In-Reply-To: <1323748328-10153-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org --===============1607571429== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 12 Dec 2011 19:52:08 -0800, Ben Widawsky wrote: > Since we don't differentiate on the different GPU read domains, it > should be safe to allow back to back reads to occur without issuing a > wait (or flush in the non-semaphore case). >=20 > This has the unfortunate side effect that we need to keep track of all > the outstanding buffer reads so that we can synchronize on a write, to > another ring (since we don't know which read finishes first). In other > words, the code is quite simple for two rings, but gets more tricky for > > 2 rings. >=20 > Here is a picture of the solution to the above problem >=20 > Ring 0 Ring 1 Ring 2 > batch 0 batch 1 batch 2 > read buffer A read buffer A wait batch 0 > wait batch 1 > write buffer A >=20 > This code is really untested. I'm hoping for some feedback if this is > worth cleaning up, and testing more thoroughly. You say it's an optimization -- do you have performance numbers? --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk7nibkACgkQHUdvYGzw6vfBCQCfdt6U6xfYTVYwikoqs2tEqXXK zBcAnjo9n+Pb6IRAYpn8/OvN0sKDj9Ka =hwUi -----END PGP SIGNATURE----- --=-=-=-- --===============1607571429== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1607571429==--