From: Dan Smith <danms@us.ibm.com>
Subject: Re: [PATCH] Fix "xm list --long" listing for removed
	devices
Date: Thu, 01 Dec 2005 10:43:35 -0800
Message-ID: <87fypcfyjs.fsf@theine.beaverton.ibm.com>
References: <87sltdhlso.fsf@theine.beaverton.ibm.com>
	<20051201183654.GA28388@leeni.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20051201183654.GA28388@leeni.uk.xensource.com> (Ewan Mellor's
	message of "Thu, 1 Dec 2005 18:36:54 +0000")
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ewan Mellor <ewan@xensource.com>
Cc: Xen Developers <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org


EM> this patch breaks 02_network_attach_detach.  

Oops, does it?  I ran xm-test over it, but I must have confused that
with the other attach-detach test that is failing right now.  Sorry
about that.

EM> In any case, I would rather have the device-specific complexity in
EM> the DevController subclasses.  

Yep, definitely.  I was too focused on the block device.  Very stupid
of me.

EM> If you want to re-work this, feel free, otherwise I'll be taking
EM> your basic idea and rejigging it so that the network-detach is not
EM> broken, and so that we get that bug fixed in the next day or so.

I'll rework it ASAP.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@us.ibm.com