Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16625125A1 for ; Fri, 29 Dec 2023 15:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="B92GTz9J"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="bp0jMUMI"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="B92GTz9J"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="bp0jMUMI" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5459B1FD32; Fri, 29 Dec 2023 15:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1703862204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bv/ML4eLEh7GG3zmCbLz0m4B/Hq7mESe3WqLqnP6FGM=; b=B92GTz9JkqtT9pXnVACRL9Bo1fLujJfxGJpI8nKpvzme0Zs3OKKZmoMec+fgrjoNBmtdYB zlW6Peh/DBoazmLA7wAchaqIwnwYZ5P+ays7IwMhv567Rgm7+7ymBtkXS0mSu3bbp8vPVK rW2brS1gS95HWaNm24qBmDLnTd+Uppg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1703862204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bv/ML4eLEh7GG3zmCbLz0m4B/Hq7mESe3WqLqnP6FGM=; b=bp0jMUMI6FjgcE56J2EwOaUwmbW0qIx1E4y9nrsu8cjjQXxmwXJrCcpvcxb6V9u8YaFG4B yNRaHJpUtkw3BKBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1703862204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bv/ML4eLEh7GG3zmCbLz0m4B/Hq7mESe3WqLqnP6FGM=; b=B92GTz9JkqtT9pXnVACRL9Bo1fLujJfxGJpI8nKpvzme0Zs3OKKZmoMec+fgrjoNBmtdYB zlW6Peh/DBoazmLA7wAchaqIwnwYZ5P+ays7IwMhv567Rgm7+7ymBtkXS0mSu3bbp8vPVK rW2brS1gS95HWaNm24qBmDLnTd+Uppg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1703862204; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bv/ML4eLEh7GG3zmCbLz0m4B/Hq7mESe3WqLqnP6FGM=; b=bp0jMUMI6FjgcE56J2EwOaUwmbW0qIx1E4y9nrsu8cjjQXxmwXJrCcpvcxb6V9u8YaFG4B yNRaHJpUtkw3BKBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 312AC133E5; Fri, 29 Dec 2023 15:03:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id hBu5CrzfjmWaAQAAD6G6ig (envelope-from ); Fri, 29 Dec 2023 15:03:24 +0000 Date: Fri, 29 Dec 2023 16:03:23 +0100 Message-ID: <87h6k1xd8k.wl-tiwai@suse.de> From: Takashi Iwai To: Aabish Malik Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org Subject: Re: [PATCH] enable SND_PCI_QUIRK for hp pavilion 14-ec1xxx series In-Reply-To: <20231229145532.46629-2-aabishmalik3337@gmail.com> References: <20231229145532.46629-2-aabishmalik3337@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Level: Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -0.41 X-Spamd-Result: default: False [-0.41 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MID_CONTAINS_FROM(1.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.11)[65.87%] X-Spam-Flag: NO On Fri, 29 Dec 2023 15:55:33 +0100, Aabish Malik wrote: > > The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. > The mute led can be enabled using the already existing > ALC287_FIXUP_HP_GPIO_LED quirk. > Tested on an HP Pavilion ec1003AU > > Signed-off-by: Aabish Malik Almost good, but... Please test your patch by yourself before submission. It's missing a comma at the new line, hence it gives the compilation error. Also, the subject line could be improved. We take usually "ALSA:" prefix, and also for this kind of stuff, "hda/realtek:" is used in addition, so the subject should be "ALSA: hda/realtek: enable SND_PCI_QUIRK for hp pavilion 14-ec1xxx series". And, when you resubmit a revised patch, put the revision number like "[PATCH v2]". thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index c3a756528..961555dfc 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF), > + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx" ALC287_FIXUP_HP_GPIO_LED) > SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), > SND_PCI_QUIRK(0x103c, 0x8a25, "HP Victus 16-d1xxx (MB 8A25)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT), > SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > -- > 2.43.0 >