Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02E91C4332F for ; Fri, 9 Dec 2022 08:56:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2EB822142; Fri, 9 Dec 2022 09:55:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2EB822142 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1670576176; bh=jPt0gZJWXZptonm7YB2AOPVWBG3fBzzvnxLR9wpk3zM=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=KV2ZQUPAJvSRdOk5sCTCLRyEp3koon4cqgEf1Z87kJXxFzN5sDpK9XqpBP+odGB7J db7UcKiI/33Lz+6EDyjVVB6bvySboJxnpFdALD+3RYrO2tiXr+3MesKaD+TMZR4aNE QvPdZStFxijsnJSZgewc4RvWPiKdHrxieZXWc1ko= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D63BEF8022B; Fri, 9 Dec 2022 09:55:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5E309F8022D; Fri, 9 Dec 2022 09:55:24 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 00FD3F800F8 for ; Fri, 9 Dec 2022 09:55:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 00FD3F800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HGUoYXeH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=R0S2CrdD Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 79E8C33800; Fri, 9 Dec 2022 08:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1670576122; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lnErAWAIZ1vIXncUqQShnCavf4TU1h1iJg34nlIaSI0=; b=HGUoYXeHwwS323qV3WSqw8G296zX/0p0qlWaMzh2b0UEB/a8qVUaYJEyFKMRRa2RtNk8ru AvDGJ+lTPqYso016X7v987jOpks4EinD8+wqaDM4QcMJg5ow+oko8yZArTVTJgVJGhHEpX NzGvGcSvS33hbAodedj25LQdTJa0krA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1670576122; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lnErAWAIZ1vIXncUqQShnCavf4TU1h1iJg34nlIaSI0=; b=R0S2CrdDdKWdvEukAhdVq0XnwsD34DA62pGpswMy4vyzMbNB9G5IssZhr3aPXqCXLPsdig kMqQ4G7zBeGaXGAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 42EB413597; Fri, 9 Dec 2022 08:55:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iweRD/r3kmN3UgAAMHmgww (envelope-from ); Fri, 09 Dec 2022 08:55:22 +0000 Date: Fri, 09 Dec 2022 09:55:21 +0100 Message-ID: <87h6y56jnq.wl-tiwai@suse.de> From: Takashi Iwai To: Cezary Rojewski Subject: Re: [PATCH] ALSA: hda: Error out if invalid stream is being setup In-Reply-To: <20221208142635.1514944-1-cezary.rojewski@intel.com> References: <20221208142635.1514944-1-cezary.rojewski@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, error27@gmail.com, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 08 Dec 2022 15:26:35 +0100, Cezary Rojewski wrote: > > Scenario when snd_hdac_stream_setup_periods() receives an instance of > struct hdac_stream with neither ->substream nor ->cstream initialized is > invalid. > > Simultaneously addresses "uninitialized symbol 'dmab'" error reported by > Smatch. > > Fixes: 3e9582267e3a ("ALSA: hda: Interrupt servicing and BDL setup for compress streams") > Signed-off-by: Cezary Rojewski Thanks, pulled now. Takashi