Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0B23C433EF for ; Tue, 28 Jun 2022 10:04:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344709AbiF1KEb (ORCPT ); Tue, 28 Jun 2022 06:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344681AbiF1KEM (ORCPT ); Tue, 28 Jun 2022 06:04:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B980C2EA1A for ; Tue, 28 Jun 2022 03:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656410646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CZkdqF7PxaI/l/1ULWxtUV2SzIUGChDa2pCYGEjPuo0=; b=WURYwZo478/aqHmDbmvt04hlWKX9/CgbKo8fU1CBzmP7mfIzY0cJE2rzFLCWiRifoD9tvK TFGHYoIobN5UZkJ/UQ4z89ktcL4Lrt0BhJIwnJGL1qp5Wr3IgAbPz4jvtB3lAyYZ8aaJjY jBKgrhOr2xtjMqi9E2BsgVpnY25lQ9Q= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-346-ozyDkkDfOhCwEOj2UUNYYA-1; Tue, 28 Jun 2022 06:04:05 -0400 X-MC-Unique: ozyDkkDfOhCwEOj2UUNYYA-1 Received: by mail-wr1-f72.google.com with SMTP id z11-20020adfc00b000000b0021a3ab8ec82so1694826wre.23 for ; Tue, 28 Jun 2022 03:04:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=CZkdqF7PxaI/l/1ULWxtUV2SzIUGChDa2pCYGEjPuo0=; b=4KwApTxRqSOkYimFkxeinLXlRdXqhQ2RXjeDSziFBVJNRrdDpQWSHFOdSomztQWCca +dbytNUsRg7v/ye3gG10CyJ+2lEQf886ZMOq6MHKH/p7HATMcZArviN2l2yQm1m+CROB OkDTsuZ7GSJUEPS2RJHe1AQWamNugzuGK1LWr4R4o5WsrxV9aVB858gGHjRoVd/m/TEJ Ho+O2UpfspRQe7Cm3y79vCdT9sYsfs2Hp0TiUmEnPzc9tqJqeyHhVc5GkJCxoBmY3229 ftD6ujDLaPXH31zhrtjNg8n+YIurkAgfg3SghCBwHDFfDLCm9AlSUm5tslhEIMZ9JioS vg8A== X-Gm-Message-State: AJIora9AYqqx9ddnL0MxFGhAwLJJL0I3Xeu+052Q3Zv4wmDK58wzv5nj A8xdGd/zvbpLQgNdoxkTPuCd3P++h8qcjV6hlmP/NIBZjDhx856wgFjJaImJMaUqnYpNG0argQu SUf332a+utfvo X-Received: by 2002:adf:d1c9:0:b0:20f:c3dc:e980 with SMTP id b9-20020adfd1c9000000b0020fc3dce980mr16503392wrd.552.1656410644090; Tue, 28 Jun 2022 03:04:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1thV9O1McPGTCkEwn4a3gYeWtN14xejhgmJ7xh5kWvZYNd+w+jW03B1+RRiGJ7d+7UuV6PQTw== X-Received: by 2002:adf:d1c9:0:b0:20f:c3dc:e980 with SMTP id b9-20020adfd1c9000000b0020fc3dce980mr16503367wrd.552.1656410643877; Tue, 28 Jun 2022 03:04:03 -0700 (PDT) Received: from fedora (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id v17-20020a5d43d1000000b0021b95bcaf7fsm13089118wrr.59.2022.06.28.03.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 03:04:03 -0700 (PDT) From: Vitaly Kuznetsov To: Maxim Levitsky , kvm@vger.kernel.org Cc: Anirudh Rayabharam , Wanpeng Li , Jim Mattson , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Sean Christopherson Subject: Re: [PATCH 00/14] KVM: nVMX: Use vmcs_config for setting up nested VMX MSRs In-Reply-To: <0739589fe08c75c563e10cb41388640c7e050a52.camel@redhat.com> References: <20220627160440.31857-1-vkuznets@redhat.com> <0739589fe08c75c563e10cb41388640c7e050a52.camel@redhat.com> Date: Tue, 28 Jun 2022 12:04:02 +0200 Message-ID: <87h745umst.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Maxim Levitsky writes: > On Mon, 2022-06-27 at 18:04 +0200, Vitaly Kuznetsov wrote: >> Changes since RFC: >> - "KVM: VMX: Extend VMX controls macro shenanigans" PATCH added and the >> infrastructure is later used in other patches [Sean] PATCHes 1-3 added >> to support the change. >> - "KVM: VMX: Clear controls obsoleted by EPT at runtime, not setup" PATCH >> added [Sean]. >> - Commit messages added. >> >> vmcs_config is a sanitized version of host VMX MSRs where some controls are >> filtered out (e.g. when Enlightened VMCS is enabled, some know bugs are >> discovered, some inconsistencies in controls are detected,...) but >> nested_vmx_setup_ctls_msrs() uses raw host MSRs instead. This may end up >> in exposing undesired controls to L1. Switch to using vmcs_config instead. >> >> Sean Christopherson (1): >> KVM: VMX: Clear controls obsoleted by EPT at runtime, not setup >> >> Vitaly Kuznetsov (13): >> KVM: VMX: Check VM_ENTRY_IA32E_MODE in setup_vmcs_config() >> KVM: VMX: Check CPU_BASED_{INTR,NMI}_WINDOW_EXITING in >> setup_vmcs_config() >> KVM: VMX: Tweak the special handling of SECONDARY_EXEC_ENCLS_EXITING >> in setup_vmcs_config() >> KVM: VMX: Extend VMX controls macro shenanigans >> KVM: VMX: Move CPU_BASED_CR8_{LOAD,STORE}_EXITING filtering out of >> setup_vmcs_config() >> KVM: VMX: Add missing VMEXIT controls to vmcs_config >> KVM: VMX: Add missing VMENTRY controls to vmcs_config >> KVM: VMX: Add missing CPU based VM execution controls to vmcs_config >> KVM: nVMX: Use sanitized allowed-1 bits for VMX control MSRs >> KVM: VMX: Store required-1 VMX controls in vmcs_config >> KVM: nVMX: Use sanitized required-1 bits for VMX control MSRs >> KVM: VMX: Cache MSR_IA32_VMX_MISC in vmcs_config >> KVM: nVMX: Use cached host MSR_IA32_VMX_MISC value for setting up >> nested MSR >> >> arch/x86/kvm/vmx/capabilities.h | 16 +-- >> arch/x86/kvm/vmx/nested.c | 37 +++--- >> arch/x86/kvm/vmx/nested.h | 2 +- >> arch/x86/kvm/vmx/vmx.c | 198 ++++++++++++++------------------ >> arch/x86/kvm/vmx/vmx.h | 118 +++++++++++++++++++ >> 5 files changed, 229 insertions(+), 142 deletions(-) >> > Sorry that I was a bit out of loop on this, so before I review it, > does this patch series solve the eVMCS issue we had alone, > or we still need the eVMCS version patch series as well? "[PATCH 00/11] KVM: VMX: Support TscScaling and EnclsExitingBitmap whith eVMCS" adds new features, namely TSC scaling for both KVM-on-Hyper-V and Hyper-V-on-KVM. This series doesn't add any features but avoids the problem reported by Anirudh by properly filtering values in L1 VMX MSRs. TL;DR: Both series are needed. -- Vitaly