From: Francisco Jerez Subject: Re: [PATCH v3 1/2] Revert "drm/i915/ehl: Update MOCS table for EHL" Date: Tue, 12 Nov 2019 15:15:28 -0800 Message-ID: <87h838znxr.fsf@riseup.net> References: <20191112224757.25116-1-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1201575050==" Return-path: Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4410D6E02B for ; Tue, 12 Nov 2019 23:14:59 +0000 (UTC) In-Reply-To: <20191112224757.25116-1-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper , intel-gfx@lists.freedesktop.org Cc: Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org --===============1201575050== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Matt Roper writes: > This reverts commit f4071997f1de016780ec6b79c63d90cd5886ee83. > > These extra EHL entries won't behave as expected without a bit more work > on the kernel side so let's drop them until that kernel work has had a > chance to land. Userspace trying to use these new entries won't get the > advantage of the new functionality these entries are meant to provide, > but at least it won't misbehave. > > When we do add these back in the future, we'll probably want to > explicitly use separate tables for ICL and EHL so that userspace > software that mistakenly uses these entries (which are undefined on ICL) > sees the same behavior it sees with all the other undefined entries. > > Cc: Francisco Jerez > Cc: Jon Bloomfield > Cc: Lucas De Marchi > Signed-off-by: Matt Roper I think f4071997f1de016780ec6b79c63d90cd5886ee83 has hit a few kernel releases already. Wouldn't it make sense to CC stable? Patch is: Reviewed-by: Francisco Jerez > --- > drivers/gpu/drm/i915/gt/intel_mocs.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/= gt/intel_mocs.c > index 6e881c735b20..06e2adbf27be 100644 > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c > @@ -200,14 +200,6 @@ static const struct drm_i915_mocs_entry broxton_mocs= _table[] =3D { > MOCS_ENTRY(15, \ > LE_3_WB | LE_TC_1_LLC | LE_LRUM(2) | LE_AOM(1), \ > L3_3_WB), \ > - /* Bypass LLC - Uncached (EHL+) */ \ > - MOCS_ENTRY(16, \ > - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \ > - L3_1_UC), \ > - /* Bypass LLC - L3 (Read-Only) (EHL+) */ \ > - MOCS_ENTRY(17, \ > - LE_1_UC | LE_TC_1_LLC | LE_SCF(1), \ > - L3_3_WB), \ > /* Self-Snoop - L3 + LLC */ \ > MOCS_ENTRY(18, \ > LE_3_WB | LE_TC_1_LLC | LE_LRUM(3) | LE_SSE(3), \ > --=20 > 2.21.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEAREIAB0WIQST8OekYz69PM20/4aDmTidfVK/WwUCXcs9EAAKCRCDmTidfVK/ WwhcAQCeUIVr4XEJKJPRx/GdXudUJ9NKQvklqPJVxyOqvWxcagD7BQmS3FnlL3kX LpHcg65r5OoPVhnHoQIdVQ66wMUTPTM= =2ojo -----END PGP SIGNATURE----- --==-=-=-- --===============1201575050== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1201575050==--