Received: from eggs.gnu.org ([209.51.188.92]:53038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwrWw-0007u3-4h for qemu-devel@nongnu.org; Thu, 21 Feb 2019 11:49:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwrWs-0008MQ-F5 for qemu-devel@nongnu.org; Thu, 21 Feb 2019 11:49:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56310) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gwrWq-0008GI-24 for qemu-devel@nongnu.org; Thu, 21 Feb 2019 11:48:57 -0500 From: Markus Armbruster References: <20190221155359.8247-1-davidkiarie4@gmail.com> <6cdbaddf-57d8-3333-c9a0-7c5f46cecab7@siemens.com> Date: Thu, 21 Feb 2019 17:48:47 +0100 In-Reply-To: <6cdbaddf-57d8-3333-c9a0-7c5f46cecab7@siemens.com> (Jan Kiszka's message of "Thu, 21 Feb 2019 17:09:40 +0100") Message-ID: <87h8cxxf2o.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/1] snip my name and email List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Eric Blake , David Kiarie , qemu-devel@nongnu.org, alexaltea123@gmail.com, peterx@redhat.com, mst@redhat.com Jan Kiszka writes: > On 21.02.19 17:05, Eric Blake wrote: >> On 2/21/19 9:53 AM, David Kiarie wrote: >>> the occurrence of my name and email on the files below may have led to >>> some confusion in the reporting of a few recent bugs. >>> >>> i have therefore choosen to snip it. >> >> Dropping an email from the copyright line makes sense; dropping the >> Copyright declaration altogether is a bit odd (the GPL works only in >> tandem with a copyright assertion) - but as you are the author of the >> line and copyright holder of your contributions, I am not in a position >> to say you are wrong in removing it, only that it looks odd. >> > > Yeah, indeed. > > David, also note that you probably have been addressed because > scripts/get_maintainer.pl will look into the git history of files that > some patch addresses and pick up significant and/or recent > contributors from there. MAINTAINERS covers these files, so the most common use of get_maintainer.pl won't list anyone not listed there: $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] Paolo Bonzini (maintainer:X86) Richard Henderson (maintainer:X86) Eduardo Habkost (maintainer:X86) "Michael S. Tsirkin" (supporter:PC) Marcel Apfelbaum (supporter:PC) qemu-devel@nongnu.org (open list:All patches CC here) David's contributions have aged out of --git: $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git "Michael S. Tsirkin" (supporter:PC,commit_signer:12/7= =3D100%,commit_signer:10/5=3D100%) Marcel Apfelbaum (supporter:PC) Paolo Bonzini (maintainer:X86) Richard Henderson (maintainer:X86,commit_signer:1/7= =3D14%) Eduardo Habkost (maintainer:X86) Peter Xu (commit_signer:6/7=3D86%,commit_signer:4/5= =3D80%) Brijesh Singh (commit_signer:5/7=3D71%,commit_s= igner:4/5=3D80%) "Alex Benn=C3=A9e" (commit_signer:1/7=3D14%) Jan Kiszka (commit_signer:1/5=3D20%) qemu-devel@nongnu.org (open list:All patches CC here) However, --git-blame still lists him: $ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame Paolo Bonzini (maintainer:X86,commits:7/24=3D29%) Richard Henderson (maintainer:X86) Eduardo Habkost (maintainer:X86,commits:7/24=3D29= %) "Michael S. Tsirkin" (supporter:PC,commits:26/24=3D100= %,commits:14/8=3D100%) Marcel Apfelbaum (supporter:PC) David Kiarie (authored lines:1176/1645=3D71%,a= uthored lines:274/373=3D73%) Brijesh Singh (authored lines:403/1645=3D24%,au= thored lines:93/373=3D25%,commits:4/8=3D50%) Peter Xu (commits:10/24=3D42%,commits:4/8=3D50%) David Gibson (commits:7/24=3D29%) Jan Kiszka (commits:1/8=3D12%) Prasad J Pandit (commits:1/8=3D12%) qemu-devel@nongnu.org (open list:All patches CC here) --help admonishes: Using "--git-blame" is slow and may add old committers and authors that are no longer active maintainers to the output. > There should be some opt-out statement from > that, but I don't recall how. I don't think get_maintainer.pl supports a blacklist of people who don't want to be pestered anymore.