Received: from eggs.gnu.org ([2001:4830:134:3::10]:46448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOjJj-0000Ow-7f for qemu-devel@nongnu.org; Mon, 19 Nov 2018 08:10:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOjJf-0001wj-6z for qemu-devel@nongnu.org; Mon, 19 Nov 2018 08:10:19 -0500 From: Markus Armbruster References: <20181116200016.2080785-1-eblake@redhat.com> Date: Mon, 19 Nov 2018 14:10:07 +0100 In-Reply-To: <20181116200016.2080785-1-eblake@redhat.com> (Eric Blake's message of "Fri, 16 Nov 2018 14:00:16 -0600") Message-ID: <87h8gdqkls.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3] qapi: Reduce Makefile boilerplate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, pbonzini@redhat.com Eric Blake writes: > Adding a new qapi module had some rather tedious repetition to > wire it into Makefile, Makefile.objs, and .gitignore (for example, > see commit bf42508f and its followup b61acdec). For make, add some > indirection by taking advantage of GNU Make string processing to > expand a list of module names into all the required artifacts, so > that future additions of a new module need only touch the list of > module names. And for gitignore, use globs to cover all generated > file names. > > The list has to live in Makefile.objs, due to the way that > our unnest-vars macro slirps in that file without remembering > any definition of $(QAPI_MODULES) from Makefile. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster