From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH v8 1/2] x86/kexec: add a new atomic notifier list for kdump Date: Mon, 26 Nov 2012 19:49:39 -0600 Message-ID: <87haobolvw.fsf@xmission.com> References: <50ADE0C2.1000106@cn.fujitsu.com> <50ADE11A.401@cn.fujitsu.com> <87ip8sxuyh.fsf@xmission.com> <20121126172054.GF12969@redhat.com> <87fw3wuuoh.fsf@xmission.com> <20121126175327.GG12969@redhat.com> <87mwy4teh8.fsf@xmission.com> <50B41849.9040103@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Gleb Natapov , "x86\@kernel.org" , "kexec\@lists.infradead.org" , Marcelo Tosatti , "linux-kernel\@vger.kernel.org" , "kvm\@vger.kernel.org" To: Zhang Yanfei Return-path: In-Reply-To: <50B41849.9040103@cn.fujitsu.com> (Zhang Yanfei's message of "Tue, 27 Nov 2012 09:32:57 +0800") Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Zhang Yanfei writes: > So in summary, > > 1. a specific callback function instead of a notifier? Yes. > 2. Instead of calling vmclear_local_loaded_vmcss, the vmclear operation > will just call the vmclear on every vmcss loaded on the cpu? > > like below: > > static void crash_vmclear_local_loaded_vmcss(void) > { > int cpu = raw_smp_processor_id(); > struct loaded_vmcs *v, *n; > > if (!crash_local_vmclear_enabled(cpu)) > return; > > list_for_each_entry_safe(v, n, &per_cpu(loaded_vmcss_on_cpu, cpu), > loaded_vmcss_on_cpu_link) > vmcs_clear(v->vmcs); > } > > right? Yeah that looks good. I would do list_for_each_entry because the list isn't changing. Eric