From: Sven Joachim Subject: Re: i915: wrong framebuffer size in 2.6.36-rc3 Date: Mon, 30 Aug 2010 15:42:32 +0200 Message-ID: <87hbiccj3r.fsf@turtle.gmx.de> References: <87wrr8cui7.fsf@turtle.gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: (Pekka Enberg's message of "Mon, 30 Aug 2010 12:57:20 +0300") Sender: linux-kernel-owner@vger.kernel.org To: Pekka Enberg Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ivan Bulatovic , Chris Wilson , Eric Anholt , Jesse Barnes , Linus Torvalds List-Id: dri-devel@lists.freedesktop.org On 2010-08-30 11:57 +0200, Pekka Enberg wrote: > On Mon, Aug 30, 2010 at 12:36 PM, Sven Joachim wrot= e: >> On my laptop which has a 1280x800 display, only the upper left 848x4= 80 >> pixels are used on the console in 2.6.36-rc3. =A0The resolution is >> correct, but /sys/class/graphics/fb0/modes looks like this: >> >> U:848x480p-0 >> >> This is a regression from 2.6.35. =A0The graphics card according to = lspci: >> >> 00:02.0 VGA compatible controller: Intel Corporation Mobile 945GM/GM= S, >> 943/940GML Express Integrated Graphics Controller (rev 03) > > Yeah, you're not alone on this: > > http://lkml.org/lkml/2010/8/23/452 Incidentally, I did not notice the problem initially described in this thread, and 2.6.36-rc2 actually seems OK for me. But after this commit= : commit 9559fcdbff4f93d29af04478bbc48294519424f5 Author: Jesse Barnes Date: Tue Aug 24 11:31:16 2010 -0700 drm/i915: fix vblank wait test condition =20 When converting this to the new wait_for macro I inverted the wait condition, which causes all sorts of problems. So correct it to fi= x several failures caused by the bad wait (flickering, bad output detection, tearing, etc.). =20 Reviewed-by: Chris Wilson Tested-by: Sitsofe Wheeler Signed-off-by: Jesse Barnes Signed-off-by: Linus Torvalds @ -992,7 +992,7 @@ void intel_wait_for_vblank(struct drm_device *dev, i= nt pipe) =20 /* Wait for vblank interrupt bit to set */ if (wait_for((I915_READ(pipestat_reg) & - PIPE_VBLANK_INTERRUPT_STATUS) =3D=3D 0, + PIPE_VBLANK_INTERRUPT_STATUS), 50, 0)) DRM_DEBUG_KMS("vblank wait timed out\n"); } only the upper left 848x480 pixels of the display are used for the framebuffer. Booting with the video=3D1280x800 commandline option work= s around this problem. Sven