Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AFB4C46467 for ; Mon, 16 Jan 2023 20:55:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2428C40BC2; Mon, 16 Jan 2023 20:55:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2428C40BC2 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t1XVPzq1SDJK; Mon, 16 Jan 2023 20:55:35 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 2F10E40BB2; Mon, 16 Jan 2023 20:55:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2F10E40BB2 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 4AB4D1BF3C6 for ; Mon, 16 Jan 2023 20:55:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2290381F7B for ; Mon, 16 Jan 2023 20:55:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2290381F7B X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Af68E88PhzgM for ; Mon, 16 Jan 2023 20:55:31 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1DE8C81F4C Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1DE8C81F4C for ; Mon, 16 Jan 2023 20:55:30 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 81F7020003; Mon, 16 Jan 2023 20:55:27 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1pHWVq-008FFv-C6; Mon, 16 Jan 2023 21:55:26 +0100 From: Peter Korsgaard To: Christian Stewart References: <20230116105032.1890904-1-peter@korsgaard.com> <20230116105032.1890904-2-peter@korsgaard.com> Date: Mon, 16 Jan 2023 21:55:26 +0100 In-Reply-To: (Christian Stewart's message of "Mon, 16 Jan 2023 12:38:27 -0800") Message-ID: <87ilh6fbcx.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 2/2] package/go: explicitly set GOMODCACHE X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anisse Astier , Buildroot Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Christian" == Christian Stewart writes: > Hi Peter, > This reminds me of when GO111MODULE was leaking from the host environment > as well. I wonder if there's any merit to wiping the host environment > variables if br2 reproducible is enabled? I definately think it is, ideally we want Buildroot to work the same way on all hosts - But why only for reproducible builds? Notice that we do override GO111MODULE= in HOST_GO_COMMON_ENV. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot