Received: from eggs.gnu.org ([2001:4830:134:3::10]:43469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKeMz-0002h1-Tt for qemu-devel@nongnu.org; Thu, 08 Nov 2018 02:04:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKeMy-0000Fo-Ui for qemu-devel@nongnu.org; Thu, 08 Nov 2018 02:04:49 -0500 From: Markus Armbruster References: <1541528230-31817-1-git-send-email-thuth@redhat.com> <12974ebb-09de-c6e9-1dd7-5199a8ae6b05@redhat.com> <87k1louaze.fsf@dusky.pond.sub.org> <4b0e9b3f-5d88-9ef2-d0c5-f241067001d0@redhat.com> Date: Thu, 08 Nov 2018 08:04:25 +0100 In-Reply-To: (Peter Maydell's message of "Wed, 7 Nov 2018 19:42:11 +0000") Message-ID: <87in18qccm.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Add an entry for the 'collie' machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Thomas Huth , Dmitry Eremin-Solenikov , qemu-arm , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , QEMU Developers Peter Maydell writes: > On 7 November 2018 at 19:39, Thomas Huth wrote: >> On 2018-11-07 17:08, Markus Armbruster wrote: >>> Peter Maydell writes: >>> >>>> On 6 November 2018 at 18:52, Thomas Huth wrote: >>>>> On 2018-11-06 19:49, Philippe Mathieu-Daud=C3=A9 wrote: >>>>>> On 6/11/18 19:17, Thomas Huth wrote: >>>>>>> There is no active maintainer, but since Peter is picking up >>>>>>> patches via qemu-arm@nongnu.org, I think we could at least use >>>>>>> "Odd Fixes" as status here. >>>>>> >>>>>> This looks more as "Orphan" to me... >>>>> >>>>> I'll leave it up to Peter for the final decision... >>>> >>>> I think we're not very consistent[*] in our usage of the various >>>> statuses in the MAINTAINERS file. I guess "Odd Fixes" makes >>>> sense in that, well, if you send a patch to this >>>> code and cc me I'll review it and put it in the tree. (This >>>> is true of any of the arm boards we have.) >>>> >>>> [*] We have one thing tagged Orphan, which is bsd-user/, >>>> and some things tagged Odd Fixes with no listed maintainer, >>>> and some things tagged Odd Fixes which are in practice more >>>> like Orphan (for instance sh4), and we list "fpu/" as >>>> Odd Fixes despite having given it a pretty thorough >>>> overhaul very recently, and so on... >>>> >>>> If you wanted a mechanizable rule, you could try something >>>> like "every file which is in status Odd Fixes or better >>>> must list with M: at least one named individual who has >>>> submitted a pull request in the last nine months" :-) >>> >>> Sounds like an excellent idea to me! >> >> Well, for me "odd fixes" means that there is someone around who might >> pick up the patch and throw it into a PULL request. That someone should be listed with M:. >> "Orphan" means it's >> mostly in vain to send patches for this subsystem, since there is nobody >> going to pick up your patch. So for the ARM boards, I'd say that "odd >> fixes" is a better choice, since Peter still picks up most of the >> patches via the "L: qemu-arm@nongnu.org" (big thanks for this, by the wa= y!). > > I think there should be a named person, though. A list > isn't a maintainer (at least not for the big whole > subsystem lists we have). Agree.