From: Markus Armbruster <armbru@redhat.com>
References: <cover.1432501932.git.crosthwaite.peter@gmail.com>
Date: Wed, 17 Jun 2015 08:32:42 +0200
In-Reply-To: <cover.1432501932.git.crosthwaite.peter@gmail.com> (Peter
	Crosthwaite's message of "Sun, 24 May 2015 14:20:39 -0700")
Message-ID: <87ioamj14l.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 0/2] monitor+disas: Remove uses of
	ENV_GET_CPU
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: rth@twiddle.net, lcapitulino@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de, Peter Crosthwaite <crosthwaite.peter@gmail.com>

Peter Crosthwaite <crosthwaitepeter@gmail.com> writes:

> Neither the monitor or disassembly core has a good reason to navigate from an
> env pointer to a cpu pointer. Disas should not need env awarness at all, that
> is removed in P2.
>
> The monitor is trickier, the env is still needed by some #ifdef switched target
> specific code but all common code only needs to trade in CPU pointers. As the
> monitor always has access to a CPU pointer naturally, remove ENV_GET_CPU usages
> (P1).
>
> This is related to my multi-arch work, where the goal is to minimise use of
> architecture defined global definitions, ENV_GET_CPU being a major headache in
> that whole effort. The longer term goal is to limit ENV_GET_CPU use to genuinely
> architecture specific code.
>
> But I think these two patches stand in their own right, so sending ahead of the
> motherload series. This brings both modules closer to common-oby-y'ification.
>
> First RFC for multi arch is avaiable here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01771.html
>
> The two patches are done together to avoid a conflict with monitor_disas which
> is touched by both patches. If one patch gets acked, the other nacked then
> either can be merged independently with trivial edits.

Applied to my (badly named) qapi-next branch, thanks!