From: Markus Armbruster <armbru@redhat.com>
References: <1414947218-7618-1-git-send-email-mst@redhat.com>
	<87bnoouxqn.fsf@blackfin.pond.sub.org>
	<20141103151955.GA14401@redhat.com>
Date: Mon, 03 Nov 2014 17:06:53 +0100
In-Reply-To: <20141103151955.GA14401@redhat.com> (Michael S. Tsirkin's message
	of "Mon, 3 Nov 2014 17:19:55 +0200")
Message-ID: <87ioiwuv36.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] qemu-char: fix tcp_get_fds
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

"Michael S. Tsirkin" <mst@redhat.com> writes:

> On Mon, Nov 03, 2014 at 04:09:36PM +0100, Markus Armbruster wrote:
>> "Michael S. Tsirkin" <mst@redhat.com> writes:
>> 
>> > tcp_get_fds API discards fds if there's more than 1 of these.
>> 
>> s/tcp_get_fds/tcp_get_msgfds/ (subject as well)
>
> Right. Too late as I sent this upstream :(

Why not simply respin with a fixed commit message?  Or ask the
maintainer to fix it up on commit?

>> What exactly doesn't work without this patch?
>
> It's only used by vhost test. It works by chance because
> it's only using 512m ram.

Would be a nice addition to the commit message.

> I tweaked vhost user test
> to use more memory (3900 instead of 512 M) and it started failing
> because it needs 3 fds then.
>
> Not yet upstreaming the test change itself, looking
> for ways to avoid using huge pages for this.

Okay :)

[...]