From: Peter Korsgaard Date: Fri, 04 Jul 2014 23:35:06 +0200 Subject: [Buildroot] [PATCH 1/4] pkg-infra: don't use DL_DIR as scratchpad for temporary downloads In-Reply-To: (Yann E. MORIN's message of "Thu, 3 Jul 2014 21:36:20 +0200") References: Message-ID: <87ionc4xkl.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Yann" == Yann E MORIN writes: > DL_DIR can be a very precious place for some users: they use it to store > all the downloaded archives to share across all their Buildroot (and > maybe non-Buildroot) builds. > We do not want to trash this location with our temporary downloads (e.g. > git, Hg, svn, cvs repository clones/checkouts, or wget, bzr tep tarballs). > Turns out that we already have some kind of scratchpad, the BUILD_DIR. > Although it is not really a disposable location, that's the best we have > so far. > Also, we create the temporary tarballs with mktemp using the final tarrball, s/tarrball/tarball/ > --- > Change v7 -> v8: > - use a cleaner and saner code path to detect errors > - convert the cp and scp helpers, too (Thomas DS) Committed, thanks. I think it would be good to either delay the creation of tmp_output until just before it it used and/or cleanup on errors to not end up with a bunch of odd named temporary files in DL_DIR, but that can be added later. -- Bye, Peter Korsgaard