From: OGAWA Hirofumi Subject: Re: [PATCH v4 1/6] fat: add i_disksize to represent uninitialized size Date: Tue, 18 Mar 2014 23:40:52 +0900 Message-ID: <87iorb4ljf.fsf@devron.myhome.or.jp> References: <1393769327-3472-1-git-send-email-linkinjeon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Amit Sahrawat To: Namjae Jeon Return-path: In-Reply-To: <1393769327-3472-1-git-send-email-linkinjeon@gmail.com> (Namjae Jeon's message of "Sun, 2 Mar 2014 23:08:47 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Namjae Jeon writes: > diff --git a/fs/fat/file.c b/fs/fat/file.c > index 9b104f5..0bf0d28 100644 > --- a/fs/fat/file.c > +++ b/fs/fat/file.c > @@ -300,8 +300,10 @@ void fat_truncate_blocks(struct inode *inode, loff_t offset) > * This protects against truncating a file bigger than it was then > * trying to write into the hole. > */ > - if (MSDOS_I(inode)->mmu_private > offset) > + if (MSDOS_I(inode)->i_disksize > offset) { > MSDOS_I(inode)->mmu_private = offset; > + MSDOS_I(inode)->i_disksize = offset; like inode initialization, we would need to set i_disksize to block boundary? > + } > > nr_clusters = (offset + (cluster_size - 1)) >> sbi->cluster_bits; > -- OGAWA Hirofumi