Received: from eggs.gnu.org ([2001:4830:134:3::10]:36962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZGnP-0004bi-H5 for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:01:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZGnK-0000aR-Nd for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:01:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZGnK-0000aK-G6 for qemu-devel@nongnu.org; Thu, 24 Oct 2013 05:01:30 -0400 From: Markus Armbruster References: <1382018101-6102-1-git-send-email-armbru@redhat.com> <1382018101-6102-3-git-send-email-armbru@redhat.com> Date: Thu, 24 Oct 2013 11:01:21 +0200 In-Reply-To: (Peter Maydell's message of "Wed, 23 Oct 2013 11:13:33 +0100") Message-ID: <87iownoxem.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , Christian Borntraeger , QEMU Developers , Anthony Liguori , Andreas =?utf-8?Q?F=C3=A4rber?= Peter Maydell writes: > On 17 October 2013 14:54, wrote: >> From: Markus Armbruster >> >> device_add plugs devices into suitable bus. For "real" buses, that >> actually connects the device. For sysbus, the connections need to be >> made separately, and device_add can't do that. The device would be >> left unconncected, and could not possibly work. > > "unconnected" Will fix. >> Many, but not all sysbus devices alreasy set > > "already" Will fix. >> cannot_instantiate_with_device_add_yet in their class init function. >> >> Set it in their abstract base's class init function >> sysbus_device_class_init(), and remove the now redundant assignments >> from device class init functions. > > So I think this change is probably OK (but see my comments on > patch 1 about what our definition of the flag is supposed to be). > But I'd like to see a list of the devices which this patch makes no-user > which previously weren't. Then I could eyeball the list and check > whether there's anything in it which shouldn't be. I'll include that list in v2. Thanks!