From: Peter Korsgaard Date: Thu, 21 Mar 2013 15:46:11 +0100 Subject: [U-Boot] [PATCH 1/2] mmc: mmc_getcd/getwp: use sensible defaults In-Reply-To: <20130321142431.GD26945@bill-the-cat> (Tom Rini's message of "Thu, 21 Mar 2013 10:24:31 -0400") References: <1363874404-7356-1-git-send-email-peter.korsgaard@barco.com> <20130321142431.GD26945@bill-the-cat> Message-ID: <87ip4kq098.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de >>>>> "Tom" == Tom Rini writes: Tom> On Thu, Mar 21, 2013 at 03:00:03PM +0100, Peter Korsgaard wrote: >> Let mmc_getcd() return true and mmc_getwp() false if mmc driver doesn't >> provide handlers for them. >> >> Signed-off-by: Peter Korsgaard Tom> Do we really need to do this? It seems like we should be working Tom> correctly here already, or we also need to fixup the weak function Tom> and/or the callers too. Well, for omap_hsmmc we currently return -1, which is kind of okay for getcd(), but if getwp() ever gets used it means we cannot write to cards. -- Bye, Peter Korsgaard