From: Eric Anholt Subject: Re: Is MI_FLUSH_ENABLE bit 12? Date: Wed, 30 Nov 2011 13:54:47 -0800 Message-ID: <87ipm1cm3c.fsf@eliezer.anholt.net> References: <861usr63vf.fsf@sumi.keithp.com> <87zkfephaa.fsf@eliezer.anholt.net> <20111130034200.GA7069@cloud01> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1201821385==" Return-path: In-Reply-To: <20111130034200.GA7069@cloud01> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: "drivers, Intel" List-Id: intel-gfx@lists.freedesktop.org --===============1201821385== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 30 Nov 2011 03:42:00 +0000, Ben Widawsky wrote: Non-text part: multipart/signed > On Tue, Nov 29, 2011 at 04:47:57PM -0800, Eric Anholt wrote: > > On Mon, 28 Nov 2011 18:48:04 -0800, "Keith Packard" = wrote: > > Non-text part: multipart/mixed > > Non-text part: multipart/signed > > >=20 > > > Just reading through vol1c.4 of the bspec this evening and found som= ething odd. > > >=20 > > > Bit 11 of MI_MODE is "Invalidate UHPTR enable". > > > Bit 12 of MI_MODE is "MI_FLUSH Enable" > > >=20 > > > And, yet, in i915_reg.h: > > >=20 > > > #define MI_MODE 0x0209c > > > # define VS_TIMER_DISPATCH (1 << 6) > > > # define MI_FLUSH_ENABLE (1 << 11) > > >=20 > > > Are we off-by-one on MI_FLUSH_ENABLE? Seems like this would cause > > > serious problems... > >=20 > > I think we are. On the other hand, based on actual behavior plus > > reading of simulator, I believe that the bit does nothing, regardless. >=20 > I do not think so. We've (Chris, I, and perhaps Jesse?) been through > this excercise at least twice before, and both times resulted in hangs > when we switched to bit 12 on Ironlake, not sure about other platforms. There is no MI_FLUSH enable bit on Ironlake in my copy of the docs. Bit 12 is MBZ on that hardware. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk7WpicACgkQHUdvYGzw6vdVxACZAdk6Ajui531uisrLbICy2niS t0UAn30d9A/FljySDsVsVuzg4m4ZVUc3 =WnQi -----END PGP SIGNATURE----- --=-=-=-- --===============1201821385== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1201821385==--