Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqUPO-0003DZ-JG for qemu-devel@nongnu.org; Wed, 23 Sep 2009 12:09:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqUPK-0003AV-SG for qemu-devel@nongnu.org; Wed, 23 Sep 2009 12:09:34 -0400 Received: from [199.232.76.173] (port=54903 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqUPK-0003AN-O8 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 12:09:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26230) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqUPJ-0007qe-0X for qemu-devel@nongnu.org; Wed, 23 Sep 2009 12:09:30 -0400 Subject: Re: [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS References: <83add4094da4dd3ddd50d849623f658e93e482c0.1253661009.git.quintela@redhat.com> <761ea48b0909230148l46b757dcwcc9d1c0d5aec9a8@mail.gmail.com> From: Markus Armbruster Date: Wed, 23 Sep 2009 18:09:25 +0200 In-Reply-To: <761ea48b0909230148l46b757dcwcc9d1c0d5aec9a8@mail.gmail.com> (Laurent Desnogues's message of "Wed\, 23 Sep 2009 10\:48\:19 +0200") Message-ID: <87iqf9iqx6.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Desnogues Cc: qemu-devel@nongnu.org, Juan Quintela Laurent Desnogues writes: > On Wed, Sep 23, 2009 at 1:19 AM, Juan Quintela wrot= e: >> ANSI c89 has been with us for a while. >> >> Signed-off-by: Juan Quintela >> --- >> =C2=A0configure | =C2=A0 =C2=A01 + >> =C2=A01 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/configure b/configure >> index 62dccd2..81b9ba8 100755 >> --- a/configure >> +++ b/configure >> @@ -1648,6 +1648,7 @@ if test "$debug" =3D "no" ; then >> =C2=A0fi >> =C2=A0QEMU_CFLAGS=3D"-Wall -Wundef -Wendif-labels -Wwrite-strings -Wmiss= ing-prototypes $QEMU_CFLAGS" >> =C2=A0QEMU_CFLAGS=3D"-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS" >> +QEMU_CFLAGS=3D"-Wold-style-declaration -Wold-style-definition $QEMU_CFL= AGS" > > Some older versions of gcc don't handle -Wold-style-declaration. > For instance gcc 4.1.2. Pretty old, do we want to support it? If yes, make configure detect whether the warning works?