Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E710EB64D9 for ; Wed, 14 Jun 2023 11:40:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3ED6B826; Wed, 14 Jun 2023 13:40:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3ED6B826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686742850; bh=xgJU3kOMEICN8fV9Ap8OL/6FgRTZt6IVKj/PGje8o64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=vChON9dJcKRAJdLmg1uQvuMkEDG4j3OD1+ifJIKE/WU/rmspsivL/pEzOAG+2mb6O XmV9FjRe+VYionNQFjlpjYJ6yxtnJ80sQuJ9lc4CxSNsvBPtlM/Tw0OTbYmmljDgcf 4Purzu7FXzCl6BU6XmL6bFqqB8ivzjJe/WKc21Oc= Received: by alsa1.perex.cz (Postfix, from userid 50401) id A0F9EF80301; Wed, 14 Jun 2023 13:39:34 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 27D58F80149; Wed, 14 Jun 2023 13:39:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 27E92F80149; Wed, 14 Jun 2023 13:39:30 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DC989F800BA for ; Wed, 14 Jun 2023 13:39:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DC989F800BA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=07UdI+Ur; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3oXH39uR Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D2975223B2; Wed, 14 Jun 2023 11:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686742765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D8T3hvxpKhTd+SYmVBu2dSFpvNLIFBT4l+91bELI0KI=; b=07UdI+UrMXyfyZR0G8X4mpXQR3Cc8m41bhHlpSMEBpg5E1F9/8rzLNDuEC+mycP8XdpdQJ xmHd3dfNJJ782xIQE1KzMc9yU5EQtqSQiWT3WOnWGoQzSMq4yiLfZYWwlcXh15+2XYn0L+ f7onX3kfTsf9FhhNtmFC1mgEuq37AWA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686742765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D8T3hvxpKhTd+SYmVBu2dSFpvNLIFBT4l+91bELI0KI=; b=3oXH39uRzpcrVMfxBbTBEbHK864JeOgzRPrg9EUEsW4ko9c2YV04NT67dUCtASBP7FQZ/R 9hGN6FZcp3DsCrCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 479DD1357F; Wed, 14 Jun 2023 11:39:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GaL9D+2miWSYIAAAMHmgww (envelope-from ); Wed, 14 Jun 2023 11:39:25 +0000 Date: Wed, 14 Jun 2023 13:39:24 +0200 Message-ID: <87jzw69ssz.wl-tiwai@suse.de> From: Takashi Iwai To: Lukasz Tyl Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, pgorgon@hem-e.com Subject: Re: [PATCH] sound: usb: quirks: add flag for HEM devices to enable native DSD playback In-Reply-To: <20230614113350.25607-1-ltyl@hem-e.com> References: <20230614113350.25607-1-ltyl@hem-e.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: D6JY7QFV2RGCSOZZLMGS7PSTH5WDAB5T X-Message-ID-Hash: D6JY7QFV2RGCSOZZLMGS7PSTH5WDAB5T X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 14 Jun 2023 13:33:50 +0200, Lukasz Tyl wrote: > > This commit adds new DEVICE_FLG with QUIRK_FLAG_DSD_RAW and Vendor Id for > HEM devices which supports native DSD. Prior to this change Linux kernel > was not enabling native DSD playback for HEM devices, and as a result, > DSD audio was being converted to PCM "on the fly". HEM devices, > when connected to the system, would only play audio in PCM format, > even if the source material was in DSD format. With the addition of new > VENDOR_FLG in the quircks.c file, the devices are now correctly > recognized, and raw DSD data is transmitted to the device, > allowing for native DSD playback. > > Signed-off-by: Lukasz Tyl > --- > sound/usb/quirks.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c > index 3ecd1ba7fd4b..1414bf15ac21 100644 > --- a/sound/usb/quirks.c > +++ b/sound/usb/quirks.c > @@ -2197,6 +2197,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = { > QUIRK_FLAG_DSD_RAW), > VENDOR_FLG(0xc502, /* HiBy devices */ > QUIRK_FLAG_DSD_RAW), > + VENDOR_FLG(0x3336, /* HEM devices */ > + QUIRK_FLAG_DSD_RAW), The entry is sorted in vendor id number. Could you try to put at the right position? thanks, Takashi