Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9DFEC2D0E3 for ; Wed, 16 Sep 2020 12:44:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5357222273 for ; Wed, 16 Sep 2020 12:44:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BbkQei1l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5357222273 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIWnc-0008UN-Eg for qemu-devel@archiver.kernel.org; Wed, 16 Sep 2020 08:44:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIWZw-0007ac-3c for qemu-devel@nongnu.org; Wed, 16 Sep 2020 08:30:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIWZp-0005XX-7E for qemu-devel@nongnu.org; Wed, 16 Sep 2020 08:30:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600259419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4fJqCNM2hMAyd2lZ6q88uhumvzg4IjMrLYRNZ1XVCw=; b=BbkQei1lkDxKduD8/Az+ayZk14pHodHmJjot2jtXVl1xhSRZ4pwZApHLPW1/a2bEQSF9D8 n7PQAmGBB30KBDF9ofkcfFv9tcpT+bFbrfqzjEvf6LMWClN4xZfAM1v9nINj4VvI9KPCIb m5gsJ+4yce0noAgPqAxyru+8BL1J62s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-WNbjnZwSPuiTzEyG_u5tsg-1; Wed, 16 Sep 2020 08:30:14 -0400 X-MC-Unique: WNbjnZwSPuiTzEyG_u5tsg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3472D18C89F1; Wed, 16 Sep 2020 12:30:13 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF2865E7A1; Wed, 16 Sep 2020 12:30:04 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 75689113864A; Wed, 16 Sep 2020 14:30:03 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH 07/37] qapi: add pylintrc References: <20200915224027.2529813-1-jsnow@redhat.com> <20200915224027.2529813-8-jsnow@redhat.com> Date: Wed, 16 Sep 2020 14:30:03 +0200 In-Reply-To: <20200915224027.2529813-8-jsnow@redhat.com> (John Snow's message of "Tue, 15 Sep 2020 18:39:57 -0400") Message-ID: <87k0wtoqes.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 02:16:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > Add a skeleton pylintrc file. Right now, it ignores quite a few things. > Files will be removed from the known-bad list throughout this and > following series as they are repaired. > > Note: Normally, pylintrc would go in the folder above the module, but as > that folder is shared by many things, it is going inside the module > folder now. > > Due to some bugs in different versions of pylint (2.5.x), pylint does > not correctly recognize when it is being run from "inside" a module, and > must be run *outside* of the module. > > Therefore, to run it, you must: > > > cd :/qemu/scripts -bash: cd: :/qemu/scripts: No such file or directory ;-P > > pylint qapi/ --rcfile=qapi/pylintrc Why not $ pylint scripts/qapi --rcfile=scripts/qapi/pylintrc > > Signed-off-by: John Snow > --- > scripts/qapi/pylintrc | 74 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 scripts/qapi/pylintrc > > diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc > new file mode 100644 > index 0000000000..c2bbb8e8e1 > --- /dev/null > +++ b/scripts/qapi/pylintrc > @@ -0,0 +1,74 @@ > +[MASTER] > + > +# Add files or directories matching the regex patterns to the blacklist. The > +# regex matches against base names, not paths. > +ignore-patterns=common.py, > + doc.py, > + error.py, > + expr.py, > + gen.py, > + parser.py, > + schema.py, > + source.py, > + types.py, > + visit.py, Already not ignored: __init__.py commands.py common.py debug.py events.py introspect.py script.py Okay. > + > + > +[MESSAGES CONTROL] > + > +# Disable the message, report, category or checker with the given id(s). You > +# can either give multiple identifiers separated by comma (,) or put this > +# option multiple times (only on the command line, not in the configuration > +# file where it should appear only once). You can also use "--disable=all" to > +# disable everything first and then reenable specific checks. For example, if > +# you want to run only the similarities checker, you can use "--disable=all > +# --enable=similarities". If you want to run only the classes checker, but have > +# no Warning level messages displayed, use "--disable=all --enable=classes > +# --disable=W". > +disable=fixme, > + missing-docstring, > + too-many-arguments, > + too-many-branches, > + too-many-statements, > + too-many-instance-attributes, I'm fine with disabling these. > + > +[REPORTS] > + > +[REFACTORING] > + > +[MISCELLANEOUS] > + > +[LOGGING] > + > +[BASIC] > + > +# Good variable names which should always be accepted, separated by a comma. > +good-names=i, > + j, > + k, > + ex, > + Run, > + _ Isn't this the default? > + > +[VARIABLES] > + > +[STRING] > + > +[SPELLING] > + > +[FORMAT] > + > +[SIMILARITIES] > + > +# Ignore imports when computing similarities. > +ignore-imports=yes Why? > + > +[TYPECHECK] > + > +[CLASSES] > + > +[IMPORTS] > + > +[DESIGN] > + > +[EXCEPTIONS] Looks like you started with output of --generate-rcfile,