Received: from eggs.gnu.org ([209.51.188.92]:45621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2ECC-0004Px-IE for qemu-devel@nongnu.org; Fri, 08 Mar 2019 07:01:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2EC8-0008Or-JZ for qemu-devel@nongnu.org; Fri, 08 Mar 2019 07:01:48 -0500 From: Markus Armbruster References: <20190307172401.29451-1-armbru@redhat.com> <20190307172401.29451-13-armbru@redhat.com> Date: Fri, 08 Mar 2019 13:01:10 +0100 In-Reply-To: (Laszlo Ersek's message of "Fri, 8 Mar 2019 09:44:27 +0100") Message-ID: <87k1h9fud5.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Markus Armbruster , qemu-devel@nongnu.org, kwolf@redhat.com, pkrempa@redhat.com, qemu-block@nongnu.org, mst@redhat.com, mreitz@redhat.com, marcandre.lureau@redhat.com, pbonzini@redhat.com, philmd@redhat.com Laszlo Ersek writes: > On 03/07/19 18:24, Markus Armbruster wrote: >> The previous commit added a way to configure firmware with -blockdev >> rather than -drive if=pflash. Document it as the preferred way. >> >> Signed-off-by: Markus Armbruster >> --- >> docs/interop/firmware.json | 21 +++++++++++++++------ >> 1 file changed, 15 insertions(+), 6 deletions(-) >> >> diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json >> index 28f9bc1591..db3cb38b6a 100644 >> --- a/docs/interop/firmware.json >> +++ b/docs/interop/firmware.json >> @@ -212,9 +212,13 @@ >> # >> # @executable: Identifies the firmware executable. The firmware >> # executable may be shared by multiple virtual machine >> -# definitions. The corresponding QEMU command line option >> -# is "-drive >> -# if=pflash,unit=0,readonly=on,file=@executable.@filename,format=@executable.@format". >> +# definitions. The preferred corresponding QEMU command >> +# line option is >> +# -drive if=none,id=pflash0,readonly=on,file=@executable.@filename,format=@executable.@format >> +# -machine pflash0=pflash0 >> +# or equivalent -blockdev. > > If we used plural here ("options"), would that be an improvement? > > The preferred corresponding QEMU command line options are > -drive ... > -machine ... > (or -blockdev equivalent to -drive). Definitely an improvement. >> +# With QEMU versions older than 4.0, you have to use > > To make this easier to understand on first read, should we say > > ... you have to use the single option ... > > ? > > (Maybe there is a better term than "single option" for the "-drive if=" options, i.e. for those that configure both back-end and front-end.) I think we can leave this one to context. > If the above over-explained things, I'd be fine with the current patch as well. I just got these ideas and wanted to run them by you. Appreciated!