Received: from eggs.gnu.org ([2001:4830:134:3::10]:58577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYfb3-0003zT-19 for qemu-devel@nongnu.org; Mon, 08 Jan 2018 17:08:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYfb1-0007tE-Ri for qemu-devel@nongnu.org; Mon, 08 Jan 2018 17:08:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44482) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYfb1-0007ru-Ku for qemu-devel@nongnu.org; Mon, 08 Jan 2018 17:08:43 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E64A461B8F for ; Mon, 8 Jan 2018 22:08:42 +0000 (UTC) From: Juan Quintela In-Reply-To: <20180105170138.23357-3-dgilbert@redhat.com> (David Alan Gilbert's message of "Fri, 5 Jan 2018 17:01:38 +0000") References: <20180105170138.23357-1-dgilbert@redhat.com> <20180105170138.23357-3-dgilbert@redhat.com> Reply-To: quintela@redhat.com Date: Mon, 08 Jan 2018 23:08:41 +0100 Message-ID: <87k1ws0zrq.fsf@secure.laptop> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/2] find_ram_offset: Align ram_addr_t allocation on long boundaries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, pbonzini@redhat.com "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The dirty bitmaps are built from 'long'sand there is fast-path code > for synchronising the case where the RAMBlock is aligned to the start > of a long boundary. Align the allocation to this boundary > to cause the fast path to be used. > > Offsets before change: > 11398@1515169675.018566:find_ram_offset size: 0x1e0000 @ 0x8000000 > 11398@1515169675.020064:find_ram_offset size: 0x20000 @ 0x81e0000 > 11398@1515169675.020244:find_ram_offset size: 0x20000 @ 0x8200000 > 11398@1515169675.024343:find_ram_offset size: 0x1000000 @ 0x8220000 > 11398@1515169675.025154:find_ram_offset size: 0x10000 @ 0x9220000 > 11398@1515169675.027682:find_ram_offset size: 0x40000 @ 0x9230000 > 11398@1515169675.032921:find_ram_offset size: 0x200000 @ 0x9270000 > 11398@1515169675.033307:find_ram_offset size: 0x1000 @ 0x9470000 > 11398@1515169675.033601:find_ram_offset size: 0x1000 @ 0x9471000 > > after change: > 10923@1515169108.818245:find_ram_offset size: 0x1e0000 @ 0x8000000 > 10923@1515169108.819410:find_ram_offset size: 0x20000 @ 0x8200000 > 10923@1515169108.819587:find_ram_offset size: 0x20000 @ 0x8240000 > 10923@1515169108.823708:find_ram_offset size: 0x1000000 @ 0x8280000 > 10923@1515169108.824503:find_ram_offset size: 0x10000 @ 0x9280000 > 10923@1515169108.827093:find_ram_offset size: 0x40000 @ 0x92c0000 > 10923@1515169108.833045:find_ram_offset size: 0x200000 @ 0x9300000 > 10923@1515169108.833504:find_ram_offset size: 0x1000 @ 0x9500000 > 10923@1515169108.833787:find_ram_offset size: 0x1000 @ 0x9540000 > > Suggested-by: Paolo Bonzini > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela