From: Eric Anholt Subject: Re: [PATCH -next] drm/pl111: Fix return value check in pl111_amba_probe() Date: Mon, 22 May 2017 15:11:42 -0700 Message-ID: <87k2587d9d.fsf@eliezer.anholt.net> References: <20170521010152.6186-1-weiyj.lk@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2067307440==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DB006E2AD for ; Mon, 22 May 2017 22:11:44 +0000 (UTC) In-Reply-To: <20170521010152.6186-1-weiyj.lk@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Wei Yongjun , David Airlie , Tom Cooksey Cc: Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2067307440== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Wei Yongjun writes: > From: Wei Yongjun > > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") > Signed-off-by: Wei Yongjun Reviewed and applied. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlkjYh4ACgkQtdYpNtH8 nujylg/9EiJk90Ix+DG44gpLD0hW8j10BQ+LXwbCWtAUVFaPbcMkZyHHBoQBClh1 +ZrKKxSCmy9L3xCllTApfSVLxdwMJgwhBAgJ9Unp2PH/WmJGcngDmSTT+XwcedDl +iTiAxW0/bI+URKmtgYXmMb8JiZejcP+002eeLfQgIVdQs0zPnGy7RMxzkN9KmIi 0n+e3YpbNVNzGBE/unEJ/mQDSrphS7riJ9y920xezgCPI19h0PivjkA9xfsezqY9 GtWrzPriiUh3WMVmfqmOsgYeNcjMjb2fS/XLXwyfXopbiQ91KM47oVbAu0dTZh4k 9LkELkENilbjZ9bsO6qzXKY4Jk5yYJPcO776DcC1e+s0try0nwhLLe+Kpx7qkpW2 qYlVDTsTH6zMHZC4gO9g95dgW6cL64qoGUGsZTnB+yuo2guUWdkI7uNxX//tfZd/ n/W4I6/tfKW2YhIA6hmUyHK14l6VeualDMydgv4kSXuMzubLnR7XIQ4Qhvep9xbr +K7KmHsdJdE1oQ1gDMw7jsHvRa8OL/mhxCA/+WU6HMMieniuM8YyqDZ/NFzricgO pWVwlggEyp3YgqW66CuxQpjjg4FD4jqOqJgWcKLG9nEzq7cTWEBH+/iBj7HgsVqU Xfm/w+WigzNVrbET10GIbMnhQshVxqldilVJnsaqNiNewbYuZk8= =5Yzw -----END PGP SIGNATURE----- --=-=-=-- --===============2067307440== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2067307440==--