Received: from eggs.gnu.org ([2001:4830:134:3::10]:58647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxBUr-0000Mn-LG for qemu-devel@nongnu.org; Tue, 26 May 2015 05:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxBUo-0008P0-GJ for qemu-devel@nongnu.org; Tue, 26 May 2015 05:50:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxBUo-0008OM-A5 for qemu-devel@nongnu.org; Tue, 26 May 2015 05:50:02 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4Q9o1QK002516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 26 May 2015 05:50:01 -0400 From: Markus Armbruster References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-21-git-send-email-armbru@redhat.com> <555FB51A.4040802@redhat.com> Date: Tue, 26 May 2015 11:49:59 +0200 In-Reply-To: <555FB51A.4040802@redhat.com> (Eric Blake's message of "Fri, 22 May 2015 17:00:42 -0600") Message-ID: <87k2vvd5x4.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 20/20] monitor: Change return type of monitor_cur_is_qmp() to bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Eric Blake writes: > On 05/22/2015 05:36 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> include/monitor/monitor.h | 2 +- >> monitor.c | 6 ++++-- >> stubs/mon-is-qmp.c | 2 +- >> 3 files changed, 6 insertions(+), 4 deletions(-) >> > >> +++ b/stubs/mon-is-qmp.c >> @@ -1,7 +1,7 @@ >> #include "qemu-common.h" >> #include "monitor/monitor.h" >> >> -int monitor_cur_is_qmp(void) >> +bool monitor_cur_is_qmp(void) >> { >> return 0; > > s/0/false/ Yes. > with that change, > Reviewed-by: Eric Blake Thanks!