Received: from eggs.gnu.org ([2001:4830:134:3::10]:57327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUvon-0005QC-B2 for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:53:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUvoh-0000FE-6f for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:53:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUvog-0000EC-UU for qemu-devel@nongnu.org; Fri, 19 Sep 2014 06:53:31 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8JArOrI017722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 19 Sep 2014 06:53:25 -0400 From: Markus Armbruster References: <1411083819-9284-1-git-send-email-jsnow@redhat.com> Date: Fri, 19 Sep 2014 12:53:22 +0200 In-Reply-To: <1411083819-9284-1-git-send-email-jsnow@redhat.com> (John Snow's message of "Thu, 18 Sep 2014 19:43:24 -0400") Message-ID: <87k34znaot.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com John Snow writes: > The original version of the AHCI test base > which is now staged for being merged, processes > the ahci_identify test in a monolithic fashion. > > In authoring new tests, it became necessary and > obvious as to how the operation of this device > should be factored out to ease the writing of > new AHCI tests. > > This patch set issues the necessary refactorings > to support future test development for AHCI. > > This patch set DOES NOT account for any new fixes > and requires no fixes from my "AHCI fixes" RFC > in order to run successfully on 2014-09-18's > origin/master. > > This patch set does not alter the operation of the > existing test, or add new tests. It only offers > refactorings for future patch submissions which > depend on them, but are still under consideration. [...] > tests/ahci-test.c | 860 ++++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 583 insertions(+), 277 deletions(-) Ignorant question: why should we commit the "monolithic" test only to refactor it extensively right away?