Received: from eggs.gnu.org ([2001:4830:134:3::10]:39695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGQEw-0007UL-2b for qemu-devel@nongnu.org; Thu, 20 Feb 2014 04:48:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGQEq-00023u-48 for qemu-devel@nongnu.org; Thu, 20 Feb 2014 04:48:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGQEp-00023n-SM for qemu-devel@nongnu.org; Thu, 20 Feb 2014 04:48:16 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1K9mEBE009247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 20 Feb 2014 04:48:15 -0500 From: Markus Armbruster References: <1392822778-4823-1-git-send-email-kwolf@redhat.com> <8761oa8d6t.fsf@blackfin.pond.sub.org> <20140220090309.GA3617@dhcp-200-207.str.redhat.com> Date: Thu, 20 Feb 2014 10:48:11 +0100 In-Reply-To: <20140220090309.GA3617@dhcp-200-207.str.redhat.com> (Kevin Wolf's message of "Thu, 20 Feb 2014 10:03:09 +0100") Message-ID: <87k3cq3yjo.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/7] qemu-img: Fix handling of multiply specified options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Kevin Wolf writes: > Am 20.02.2014 um 08:18 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > If you specify the same option more than once (e.g. -o cluster_size=4k >> > -o lazy_refcounts=on), qemu-img silently ignores all but the last one. This >> >> Sounds like perfectly common behavior to me. > > I guess it depends on the kind of option. For -o it's no less surprising > than 'gcc -Wall -Werror' giving you only -Werror without -Wall. I agree that multiple -OPT KEY=VALUE,... accumulating is nicer than the last one wiping out its predecessors. >> > series fixes it to either consider all options or to give an error message. >> >> Doesn't this break usage like "Compiled-in default is no good for me, >> create wrapper script setting my defaults followed by "$@", then >> override them on command line"? > > It does. Would you be happy with a series that accumulates -o options > (like this one does) and leaves the other options alone? No objections.