From: Eric Anholt Subject: Re: Is MI_FLUSH_ENABLE bit 12? Date: Tue, 06 Dec 2011 11:56:07 -0800 Message-ID: <87k469iieg.fsf@eliezer.anholt.net> References: <861usr63vf.fsf@sumi.keithp.com> <87zkfephaa.fsf@eliezer.anholt.net> <20111130034200.GA7069@cloud01> <87ipm1cm3c.fsf@eliezer.anholt.net> <20111205145709.5a12cee4@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1703841326==" Return-path: In-Reply-To: <20111205145709.5a12cee4@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Ben Widawsky , "drivers, Intel" List-Id: intel-gfx@lists.freedesktop.org --===============1703841326== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 5 Dec 2011 14:57:09 -0800, Jesse Barnes = wrote: > On Wed, 30 Nov 2011 13:54:47 -0800 > Eric Anholt wrote: >=20 > > On Wed, 30 Nov 2011 03:42:00 +0000, Ben Widawsky wro= te: > > Non-text part: multipart/signed > > > On Tue, Nov 29, 2011 at 04:47:57PM -0800, Eric Anholt wrote: > > > > On Mon, 28 Nov 2011 18:48:04 -0800, "Keith Packard" wrote: > > > > Non-text part: multipart/mixed > > > > Non-text part: multipart/signed > > > > >=20 > > > > > Just reading through vol1c.4 of the bspec this evening and found= something odd. > > > > >=20 > > > > > Bit 11 of MI_MODE is "Invalidate UHPTR enable". > > > > > Bit 12 of MI_MODE is "MI_FLUSH Enable" > > > > >=20 > > > > > And, yet, in i915_reg.h: > > > > >=20 > > > > > #define MI_MODE 0x0209c > > > > > # define VS_TIMER_DISPATCH (1 << 6) > > > > > # define MI_FLUSH_ENABLE (1 << 11) > > > > >=20 > > > > > Are we off-by-one on MI_FLUSH_ENABLE? Seems like this would cause > > > > > serious problems... > > > >=20 > > > > I think we are. On the other hand, based on actual behavior plus > > > > reading of simulator, I believe that the bit does nothing, regardle= ss. > > >=20 > > > I do not think so. We've (Chris, I, and perhaps Jesse?) been through > > > this excercise at least twice before, and both times resulted in hangs > > > when we switched to bit 12 on Ironlake, not sure about other platform= s. > >=20 > > There is no MI_FLUSH enable bit on Ironlake in my copy of the docs. Bit > > 12 is MBZ on that hardware. >=20 > It's one of those "been there forever" bits. A comment wouldn't hurt, > but we should also put in a doc change request (in fact I think I did > that but it went into a black hole). Well, by "been there forever", you mean "introduced in: commit a69ffdbfcba8eabf2ca9d384b578e6f28b339c61 Author: Zhenyu Wang Date: Mon Aug 30 16:12:42 2010 +0800 drm/i915: Enable MI_FLUSH on Sandybridge =20=20=20=20 MI_FLUSH is being deprecated, but still available on Sandybridge. Make sure it's enabled as userspace still uses MI_FLUSH. =20=20=20=20 Signed-off-by: Zhenyu Wang Cc: stable@kernel.org Signed-off-by: Chris Wilson " It should be removed on Ironlake, and fixed to be 12 on SNB or just removed. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk7ec1cACgkQHUdvYGzw6vde4gCeP1kiwvK00KLYTfQCInG0hc5q MrMAni/Z0X9beuwZ3Y3FqEmRZobMj44w =i9XD -----END PGP SIGNATURE----- --=-=-=-- --===============1703841326== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1703841326==--