From: OGAWA Hirofumi Subject: Re: [PATCH][RFC] vfs: block_read_full_page allocates array depending on environment Date: Sat, 30 Jan 2010 15:19:24 +0900 Message-ID: <87k4v0f72r.fsf@devron.myhome.or.jp> References: <20100129095356.265D.61FB500B@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Viro , linux-fsdevel@vger.kernel.org To: Masayoshi MIZUMA Return-path: Received: from mail.parknet.co.jp ([210.171.160.6]:47791 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755Ab0A3GT3 (ORCPT ); Sat, 30 Jan 2010 01:19:29 -0500 In-Reply-To: <20100129095356.265D.61FB500B@jp.fujitsu.com> (Masayoshi MIZUMA's message of "Fri, 29 Jan 2010 09:53:58 +0900") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Masayoshi MIZUMA writes: > @@ -2146,13 +2146,12 @@ int block_read_full_page(struct page *page, get_block_t *get_block) > { > struct inode *inode = page->mapping->host; > sector_t iblock, lblock; > - struct buffer_head *bh, *head, *arr[MAX_BUF_PER_PAGE]; > - unsigned int blocksize; > + unsigned int blocksize = 1 << inode->i_blkbits; > + struct buffer_head *bh, *head, *arr[PAGE_CACHE_SIZE / blocksize]; In practice, we avoid to use the variable-length array on the kernel stack. Although I'm not sure how important it is, there are some reasons to avoid. Also sparse will warn it, IIRC. Thanks. > int nr, i; > int fully_mapped = 1; > > BUG_ON(!PageLocked(page)); > - blocksize = 1 << inode->i_blkbits; > if (!page_has_buffers(page)) > create_empty_buffers(page, blocksize, 0); > head = page_buffers(page); -- OGAWA Hirofumi