DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4187B61452
From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas De Schampheleire <patrickdepinguin@gmail.com>
References: <20210913072942.30109-1-patrickdepinguin@gmail.com>
 <20210913072942.30109-2-patrickdepinguin@gmail.com>
Date: Mon, 04 Oct 2021 22:24:55 +0200
In-Reply-To: <20210913072942.30109-2-patrickdepinguin@gmail.com> (Thomas De
 Schampheleire's message of "Mon, 13 Sep 2021 09:29:42 +0200")
Message-ID: <87lf38fsh4.fsf@dell.be.48ers.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Subject: Re: [Buildroot] [PATCH 2/2] toolchain/helpers.mk: gdbinit: set
 auto-load-safe-path before sysroot
Precedence: list
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
 Giulio Benetti <giulio.benetti@benettiengineering.com>,
 Romain Naour <romain.naour@gmail.com>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: buildroot-bounces@buildroot.org
Sender: "buildroot" <buildroot-bounces@buildroot.org>

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:

 > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > The gdbinit supplied by Buildroot does two things:
 > A. specify the sysroot where gdb can find shared libraries
 > B. mark the sysroot as a 'safe path' for its auto-load feature, to make sure
 >   that pretty printers for libstdc++.so are added automatically (see commit
 >   6fb3216a80c64c08375429d89497eaeec5622150)

 > When debugging a core file, and the gdbinit file is specified via '-x'
 > rather than '-ix', then the order of these settings matters: If you first
 > set the sysroot, then gdb will immediately start finding the shared
 > libraries it needs for the core file, detect libstdc++ and its associated
 > libstdc++-gdb.py file, then give a big warning about safe paths:

 >   warning: File ".../i686-buildroot-linux-gnu/sysroot/lib/libstdc++.so.6.0.24-gdb.py"
 >           auto-loading has been declined by your `auto-load safe-path' set
 >           to "$debugdir:$datadir/auto-load".
 >   To enable execution of this file add
 >           add-auto-load-safe-path .../i686-buildroot-linux-gnu/sysroot/lib/libstdc++.so.6.0.24-gdb.py
 >   line to your configuration file "/home/me/.gdbinit".
 >   To completely disable this security protection add
 >           set auto-load safe-path /
 >   line to your configuration file "/home/me/.gdbinit".
 >   For more information about this security protection see the
 >   "Auto-loading safe path" section in the GDB manual.  E.g., run from the shell:
 >           info "(gdb)Auto-loading safe path"

 > and the pretty printing code is not loaded. This is because the second
 > line from the gdbinit file was not yet parsed at this point.

 > By changing the order (first configuring the safe path, then setting the
 > sysroot), this issue does not appear and everything is as expected.

 > Note that when '-ix' were used instead of '-x' to pass the gdbinit file to
 > gdb, then the order would not matter, because the entire gdbinit file would
 > be parsed before considering the core file.
 > However, even though the Buildroot manual now suggests '-ix', users may not
 > have noticed this change and continue to use '-x'.

 > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Committed to 2021.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot