Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7DD5C433E3 for ; Mon, 3 Aug 2020 10:41:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96E5F20738 for ; Mon, 3 Aug 2020 10:41:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mork.no header.i=@mork.no header.b="drTWXDkh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726321AbgHCKln (ORCPT ); Mon, 3 Aug 2020 06:41:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbgHCKlm (ORCPT ); Mon, 3 Aug 2020 06:41:42 -0400 Received: from canardo.mork.no (canardo.mork.no [IPv6:2001:4641::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CBF6C06174A; Mon, 3 Aug 2020 03:41:42 -0700 (PDT) Received: from miraculix.mork.no (miraculix.mork.no [IPv6:2001:4641:0:2:7627:374e:db74:e353]) (authenticated bits=0) by canardo.mork.no (8.15.2/8.15.2) with ESMTPSA id 073AesFj020085 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 3 Aug 2020 12:40:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1596451255; bh=sbO29wH2iO2+x7SK3Zlts21jZX4eIU9YpmoVEt1ZL7k=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=drTWXDkhr7GiZjh19NA5scC5D6LIJ+0wMGxz4Bwp8zydwY22yIBBjhgLHjAedrCtX wBp3xpd8oTT8yjF5CogqL7OELT1nStp6a0MtkEf7cLIzuZTDfho1dKZun9vBhDMyXn tp8aGlgHlEOt//TII+owcnChrKEeqbwg5wb40DFM= Received: from bjorn by miraculix.mork.no with local (Exim 4.94) (envelope-from ) id 1k2Xtm-000IZu-E7; Mon, 03 Aug 2020 12:40:54 +0200 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Daniele Palmas Cc: Greg KH , yzc666@netease.com, David Miller , kuba@kernel.org, netdev@vger.kernel.org, linux-usb , carl Subject: Re: [PATCH] qmi_wwan: support modify usbnet's rx_urb_size Organization: m References: <20200803065105.8997-1-yzc666@netease.com> <20200803081604.GC493272@kroah.com> <20200803094931.GD635660@kroah.com> Date: Mon, 03 Aug 2020 12:40:54 +0200 In-Reply-To: (Daniele Palmas's message of "Mon, 3 Aug 2020 12:33:03 +0200") Message-ID: <87lfiw9fm1.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.102.4 at canardo X-Virus-Status: Clean Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Daniele Palmas writes: > Il giorno lun 3 ago 2020 alle ore 11:49 Greg KH > ha scritto: >> >> Where does QMI_WDA_SET_DATA_FORMAT come from? >> > > This is a request of Qualcomm proprietary protocol used, among other > things, to configure data aggregation for modems. There's an open > source userspace implementation in the libqmi project > (https://cgit.freedesktop.org/libqmi/tree/data/qmi-service-wda.json) > >> And the commit log says that this "depends on the chipset being used", >> so why don't you know that at probe time, does the chipset change? :) >> > > Me too does not understand this, I let the author explain... > >> > Currently there's a workaround for setting rx_urb_size i.e. changing >> > the network interface MTU: this is fine for most uses with qmap, but >> > there's the limitation that certain values (multiple of the endpoint >> > size) are not allowed. >> >> Why not just set it really high to start with? That should not affect >> any older devices, as the urb size does not matter. The only thing is >> if it is too small that things can not move as fast as they might be >> able to. >> > > Yes, this was proposed in the past by Bj=C3=B8rn > (https://lists.freedesktop.org/archives/libqmi-devel/2020-February/003221= .html), > but I was not sure about issues with old modems. Ah, right. Forgot about that. > Now I understand that there are no such issues, then I agree this is > the simplest solution: I've seen modems requiring as much as 49152, > but usually the default for qmap is <=3D 16384. > > And, by the way, increasing the rx urb size is required also in > non-qmap mode, since the current value leads to babbling issues with > some chipsets (mine > https://www.spinics.net/lists/linux-usb/msg198025.html and Paul's > https://lists.freedesktop.org/archives/libqmi-devel/2020-February/003217.= html), > so I think we should definitely increase this also for non-qmap mode. > > Bj=C3=B8rn, what do you think? I think we have good enough reasons to increase the rx urb size by default. Let's try. Bj=C3=B8rn