Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D527FA372C for ; Fri, 8 Nov 2019 08:07:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16FE521D7E for ; Fri, 8 Nov 2019 08:07:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WNmdmjqb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16FE521D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSzIS-0003NH-9a for qemu-devel@archiver.kernel.org; Fri, 08 Nov 2019 03:07:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47884) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSzHP-0002tX-IS for qemu-devel@nongnu.org; Fri, 08 Nov 2019 03:06:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSzHM-0006w8-S7 for qemu-devel@nongnu.org; Fri, 08 Nov 2019 03:06:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33571 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSzHM-0006w2-N2 for qemu-devel@nongnu.org; Fri, 08 Nov 2019 03:06:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573200360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kSiSeQVgJR08TZkUkWpYmEPSA64Rx6g+/NfobV49hls=; b=WNmdmjqbhu7Fg2C1L1Xz7xgsizLnfqtOvxggoSpOnBnWc43vd5IoRQjkKbhMu6nsk/ReN4 qYehjUOwQ5u0FuPtlNaHG+18efHVLHFr0iLAnZTdS2G7MexwUkMx4GHcPV4L2cZyAi7L2K nTOBELrdiXrW283j2pSLu38NeTDnLJg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-131-UxrA5ExZPi2HY_qAhqoh7A-1; Fri, 08 Nov 2019 03:05:56 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A396800C72; Fri, 8 Nov 2019 08:05:55 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D23865C548; Fri, 8 Nov 2019 08:05:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id EAD7D11385C9; Fri, 8 Nov 2019 09:05:52 +0100 (CET) From: Markus Armbruster To: Tao Xu Subject: Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time References: <20191028075220.25673-1-tao3.xu@intel.com> <20191028075220.25673-4-tao3.xu@intel.com> <20191106205359.GR3812@habkost.net> <1f2fa942-0993-548b-1f5c-8345d564bf29@intel.com> <20191107133112.GS3812@habkost.net> <9ecafb7f-69b9-870b-b109-939fef47acde@intel.com> Date: Fri, 08 Nov 2019 09:05:52 +0100 In-Reply-To: <9ecafb7f-69b9-870b-b109-939fef47acde@intel.com> (Tao Xu's message of "Fri, 8 Nov 2019 13:25:34 +0800") Message-ID: <87lfsqbxnj.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: UxrA5ExZPi2HY_qAhqoh7A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "lvivier@redhat.com" , "thuth@redhat.com" , Eduardo Habkost , "mst@redhat.com" , "Liu, Jingqi" , "Du, Fan" , "mdroth@linux.vnet.ibm.com" , "qemu-devel@nongnu.org" , "jonathan.cameron@huawei.com" , "imammedo@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Tao Xu writes: > On 11/7/2019 9:31 PM, Eduardo Habkost wrote: >> On Thu, Nov 07, 2019 at 02:24:52PM +0800, Tao Xu wrote: >>> On 11/7/2019 4:53 AM, Eduardo Habkost wrote: >>>> On Mon, Oct 28, 2019 at 03:52:12PM +0800, Tao Xu wrote: >>>>> Add tests for time input such as zero, around limit of precision, >>>>> signed upper limit, actual upper limit, beyond limits, time suffixes, >>>>> and etc. >>>>> >>>>> Signed-off-by: Tao Xu >>>>> --- >>>> [...] >>>>> + /* Close to signed upper limit 0x7ffffffffffffc00 (53 msbs set) = */ >>>>> + qdict =3D keyval_parse("time1=3D9223372036854774784," /* 7ffffff= ffffffc00 */ >>>>> + "time2=3D9223372036854775295", /* 7ffffffff= ffffdff */ >>>>> + NULL, &error_abort); >>>>> + v =3D qobject_input_visitor_new_keyval(QOBJECT(qdict)); >>>>> + qobject_unref(qdict); >>>>> + visit_start_struct(v, NULL, NULL, 0, &error_abort); >>>>> + visit_type_time(v, "time1", &time, &error_abort); >>>>> + g_assert_cmphex(time, =3D=3D, 0x7ffffffffffffc00); >>>>> + visit_type_time(v, "time2", &time, &error_abort); >>>>> + g_assert_cmphex(time, =3D=3D, 0x7ffffffffffffc00); >>>> >>>> I'm confused by this test case and the one below[1]. Are these >>>> known bugs? Shouldn't we document them as known bugs? >>> >>> Because do_strtosz() or do_strtomul() actually parse with strtod(), so = the >>> precision is 53 bits, so in these cases, 7ffffffffffffdff and >>> fffffffffffffbff are rounded. >> >> My questions remain: why isn't this being treated like a bug? >> > Hi Markus, > > I am confused about the code here too. Because in do_strtosz(), the > upper limit is > > val * mul >=3D 0xfffffffffffffc00 > > So some data near 53 bit may be rounded. Is there a bug? No, but the design is surprising, and the functions lack written contracts, except for the do_strtosz() helper, which has one that sucks. qemu_strtosz() & friends are designed to accept fraction * unit multiplier. Example: 1.5M means 1.5 * 1024 * 1024 with qemu_strtosz() and qemu_strtosz_MiB(), and 1.5 * 1000 * 1000 with qemu_strtosz_metric(). Whether supporting fractions is a good idea is debatable, but it's what we've got. The implementation limits the numeric part to the precision of double, i.e. 53 bits. "8PiB should be enough for anybody." Switching it from double to long double raises the limit to the precision of long double. At least 64 bit on common hosts, but hosts exist where it's the same 53 bits. Do we support any such hosts? If yes, then we'd make the precision depend on the host, which feels like a bad idea. A possible alternative is to parse the numeric part both as a double and as a 64 bit unsigned integer, then use whatever consumes more characters. This enables providing full 64 bits unless you actually use a fraction. As far as I remember, the only problem we've ever had with the 53 bits limit is developer confusion :) Patches welcome.