Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BA3C5B578 for ; Wed, 3 Jul 2019 06:37:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA16921881 for ; Wed, 3 Jul 2019 06:37:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA16921881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiYty-00071R-4g for qemu-devel@archiver.kernel.org; Wed, 03 Jul 2019 02:37:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51237) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiYsz-0006ZX-TO for qemu-devel@nongnu.org; Wed, 03 Jul 2019 02:36:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiYsy-0000lG-Sz for qemu-devel@nongnu.org; Wed, 03 Jul 2019 02:36:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52362) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiYsy-0000jy-Nj for qemu-devel@nongnu.org; Wed, 03 Jul 2019 02:36:56 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1DEA43083391; Wed, 3 Jul 2019 06:36:55 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-102.ams2.redhat.com [10.36.116.102]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF602174A7; Wed, 3 Jul 2019 06:36:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6F84A1132ABF; Wed, 3 Jul 2019 08:36:53 +0200 (CEST) From: Markus Armbruster To: Denis Plotnikov References: <20190610105906.28524-1-dplotnikov@virtuozzo.com> Date: Wed, 03 Jul 2019 08:36:53 +0200 In-Reply-To: <20190610105906.28524-1-dplotnikov@virtuozzo.com> (Denis Plotnikov's message of "Mon, 10 Jun 2019 13:59:06 +0300") Message-ID: <87lfxfy67u.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 03 Jul 2019 06:36:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: den@virtuozzo.com, dgilbert@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Did this fall through the cracks? Denis Plotnikov writes: > Right now QMP and HMP monitors read 1 byte at a time from the socket, which > is very inefficient. With 100+ VMs on the host this easily reasults in > a lot of unnecessary system calls and CPU usage in the system. Yes, reading one byte at a time is awful. But QMP is control plane; I didn't expect it to impact system performance. How are you using QMP? Just curious, not actually opposed to improving QMP efficiency. > This patch changes the amount of data to read to 4096 bytes, which matches > buffer size on the channel level. Fortunately, monitor protocol is > synchronous right now thus we should not face side effects in reality. > > Signed-off-by: Denis V. Lunev > Signed-off-by: Denis Plotnikov > --- > include/monitor/monitor.h | 2 +- > monitor.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h > index c1b40a9cac..afa1ed34a4 100644 > --- a/include/monitor/monitor.h > +++ b/include/monitor/monitor.h > @@ -14,7 +14,7 @@ extern __thread Monitor *cur_mon; > #define MONITOR_USE_CONTROL 0x04 > #define MONITOR_USE_PRETTY 0x08 > > -#define QMP_REQ_QUEUE_LEN_MAX 8 > +#define QMP_REQ_QUEUE_LEN_MAX 4096 This looks suspicious. It's a request count, not a byte count. Can you explain what led you to change it this way? > > bool monitor_cur_is_qmp(void); > > diff --git a/monitor.c b/monitor.c > index 4807bbe811..a08e020b61 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -4097,7 +4097,7 @@ static int monitor_can_read(void *opaque) > { > Monitor *mon = opaque; > > - return !atomic_mb_read(&mon->suspend_cnt); > + return !atomic_mb_read(&mon->suspend_cnt) ? 4096 : 0; > } > > /* The ramifications are not obvious to me. I think I need to (re-)examine how QMP reads input, with special consideration to its OOB feature.