Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hOMOD-00006t-2x for mharc-qemu-trivial@gnu.org; Wed, 08 May 2019 09:13:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOMOA-000054-O5 for qemu-trivial@nongnu.org; Wed, 08 May 2019 09:13:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOMO9-0000LY-Rp for qemu-trivial@nongnu.org; Wed, 08 May 2019 09:13:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51096) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOMO3-0000Fi-Eq; Wed, 08 May 2019 09:13:32 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74FF9309B167; Wed, 8 May 2019 13:13:30 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B39419729; Wed, 8 May 2019 13:13:28 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 89C771132B35; Wed, 8 May 2019 15:13:25 +0200 (CEST) From: Markus Armbruster To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= References: <20190508075527.32164-1-thuth@redhat.com> Date: Wed, 08 May 2019 15:13:25 +0200 In-Reply-To: <20190508075527.32164-1-thuth@redhat.com> (Thomas Huth's message of "Wed, 8 May 2019 09:55:27 +0200") Message-ID: <87lfzh143u.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 08 May 2019 13:13:30 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] tests/Makefile: Remove unused test-obj-y variable X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2019 13:13:40 -0000 Thomas Huth writes: > I recently noticed that test-obj-y contains a file called > tests/check-block-qtest.o which simply does not belong to any .c > file and thus wondered why this is not causing any trouble. It is > only used to add -Itests to the command line (which refers to the > build directory). However, it is not needed because "-iquote $(@D)" > already sets this up in rules.mak. Thus we can simply remove this > variable. > > Signed-off-by: Thomas Huth Reviewed-by: Markus Armbruster