From: Mika Kuoppala Subject: Re: [PATCH 02/20] drm/i915: Generalise common GPU engine reset request/unrequest code Date: Fri, 22 Jan 2016 13:24:56 +0200 Message-ID: <87lh7h6elz.fsf@gaia.fi.intel.com> References: <1452706112-8617-1-git-send-email-arun.siluvery@linux.intel.com> <1452706112-8617-3-git-send-email-arun.siluvery@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 554BB6E2E9 for ; Fri, 22 Jan 2016 03:27:07 -0800 (PST) In-Reply-To: <1452706112-8617-3-git-send-email-arun.siluvery@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arun Siluvery , intel-gfx@lists.freedesktop.org Cc: Tomas Elf List-Id: intel-gfx@lists.freedesktop.org QXJ1biBTaWx1dmVyeSA8YXJ1bi5zaWx1dmVyeUBsaW51eC5pbnRlbC5jb20+IHdyaXRlczoKCj4g RnJvbTogVG9tYXMgRWxmIDx0b21hcy5lbGZAaW50ZWwuY29tPgo+Cj4gR1BVIGVuZ2luZSByZXNl dCBoYW5kc2hha2luZyBpcyBzb21ldGhpbmcgdGhhdCBpcyBhcHBsaWNhYmxlIHRvIGJvdGggZnVs bCBHUFUKPiByZXNldCBhbmQgZW5naW5lIHJlc2V0LCB3aGljaCBpcyBzb21ldGhpbmcgdGhhdCBp cyBwYXJ0IG9mIHRoZSB1cGNvbWluZyBURFIKPiBwZXItZW5naW5lIGhhbmcgcmVjb3ZlcnkgcGF0 Y2hlcy4gQnJlYWsgb3V0IHRoZSBjb21tb24gZW5naW5lIHJlc2V0Cj4gcmVxdWVzdC91bnJlcXVl c3QgY29kZSAob3JpZ2luYWxseSB3cml0dGVuIGJ5IE1pa2EgS3VvcHBhbGEpIGZvciByZXVzZSBs YXRlciBpbgo+IHRoZSBURFIgZW5hYmxlbWVudCBwYXRjaCBzZXJpZXMuCj4KPiBTaWduZWQtb2Zm LWJ5OiBUb21hcyBFbGYgPHRvbWFzLmVsZkBpbnRlbC5jb20+Cj4gQ2M6IE1pa2EgS3VvcHBhbGEg PG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF91bmNvcmUuYyB8IDQ2ICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiBpbmRleCBjM2MxM2RjLi4yZGY0 MjQ2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiBAQCAtMTUyOSwzMiAr MTUyOSw1MCBAQCBzdGF0aWMgaW50IHdhaXRfZm9yX3JlZ2lzdGVyKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiAgCXJldHVybiB3YWl0X2ZvcigoSTkxNV9SRUFEKHJlZykgJiBt YXNrKSA9PSB2YWx1ZSwgdGltZW91dF9tcyk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbmxpbmUgaW50 IGdlbjhfcmVxdWVzdF9lbmdpbmVfcmVzZXQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l KQo+ICt7CgpJbmxpbmUgaXMgc3VwZXJmbHVvdXMgaGVyZS4gUGxlYXNlIHJlbW92ZS4KCj4gKwlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmdpbmUtPmRldi0+ZGV2X3ByaXZh dGU7Cj4gKwlpbnQgcmV0ID0gMDsKCk5vIG5lZWQgdG8gc2V0IHJldCB0byB6ZXJvLgoKPiArCj4g KwlJOTE1X1dSSVRFKFJJTkdfUkVTRVRfQ1RMKGVuZ2luZS0+bW1pb19iYXNlKSwKPiArCQkgICBf TUFTS0VEX0JJVF9FTkFCTEUoUkVTRVRfQ1RMX1JFUVVFU1RfUkVTRVQpKTsKPiArCgpJbmRlbnRh dGlvbiBzZWVtcyB0byBiZSBiaXQgb2ZmIGhlcmUuLgoKPiArCXJldCA9IHdhaXRfZm9yX3JlZ2lz dGVyKGRldl9wcml2LAo+ICsJCQkgICAgICBSSU5HX1JFU0VUX0NUTChlbmdpbmUtPm1taW9fYmFz ZSksCj4gKwkJCSAgICAgIFJFU0VUX0NUTF9SRUFEWV9UT19SRVNFVCwKPiArCQkJICAgICAgUkVT RVRfQ1RMX1JFQURZX1RPX1JFU0VULAo+ICsJCQkgICAgICA3MDApOwoKYW5kIGhlcmUgCgo+ICsJ aWYgKHJldCkKPiArCQlEUk1fRVJST1IoIiVzOiByZXNldCByZXF1ZXN0IHRpbWVvdXRcbiIsIGVu Z2luZS0+bmFtZSk7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsKPiArc3RhdGljIGlubGlu ZSBpbnQgZ2VuOF91bnJlcXVlc3RfZW5naW5lX3Jlc2V0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MK PiAqZW5naW5lKQoKUmVtb3ZlIGlubGluZSBhbmQgZG8gbm90IHJldHVybiB2YWx1ZSBpZiB0aGVy ZQppcyBubyB1c2UgZm9yIGl0LgoKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gZW5naW5lLT5kZXYtPmRldl9wcml2YXRlOwo+ICsKPiArCUk5MTVfV1JJVEUoUklO R19SRVNFVF9DVEwoZW5naW5lLT5tbWlvX2Jhc2UpLAo+ICsJCV9NQVNLRURfQklUX0RJU0FCTEUo UkVTRVRfQ1RMX1JFUVVFU1RfUkVTRVQpKTsKPiArCmluZGVudC4KCldpdGggdGhlc2UgZG9uZSwg eW91IGNhbiBhZGQgbXkgci1iLgoKLU1pa2EKCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAgc3Rh dGljIGludCBnZW44X2RvX3Jlc2V0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAlz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4gIAlpbnQgaTsKPiAgCj4gLQlmb3JfZWFj aF9yaW5nKGVuZ2luZSwgZGV2X3ByaXYsIGkpIHsKPiAtCQlJOTE1X1dSSVRFKFJJTkdfUkVTRVRf Q1RMKGVuZ2luZS0+bW1pb19iYXNlKSwKPiAtCQkJICAgX01BU0tFRF9CSVRfRU5BQkxFKFJFU0VU X0NUTF9SRVFVRVNUX1JFU0VUKSk7Cj4gLQo+IC0JCWlmICh3YWl0X2Zvcl9yZWdpc3RlcihkZXZf cHJpdiwKPiAtCQkJCSAgICAgIFJJTkdfUkVTRVRfQ1RMKGVuZ2luZS0+bW1pb19iYXNlKSwKPiAt CQkJCSAgICAgIFJFU0VUX0NUTF9SRUFEWV9UT19SRVNFVCwKPiAtCQkJCSAgICAgIFJFU0VUX0NU TF9SRUFEWV9UT19SRVNFVCwKPiAtCQkJCSAgICAgIDcwMCkpIHsKPiAtCQkJRFJNX0VSUk9SKCIl czogcmVzZXQgcmVxdWVzdCB0aW1lb3V0XG4iLCBlbmdpbmUtPm5hbWUpOwo+ICsJZm9yX2VhY2hf cmluZyhlbmdpbmUsIGRldl9wcml2LCBpKQo+ICsJCWlmIChnZW44X3JlcXVlc3RfZW5naW5lX3Jl c2V0KGVuZ2luZSkpCj4gIAkJCWdvdG8gbm90X3JlYWR5Owo+IC0JCX0KPiAtCX0KPiAgCj4gIAly ZXR1cm4gZ2VuNl9kb19yZXNldChkZXYpOwo+ICAKPiAgbm90X3JlYWR5Ogo+ICAJZm9yX2VhY2hf cmluZyhlbmdpbmUsIGRldl9wcml2LCBpKQo+IC0JCUk5MTVfV1JJVEUoUklOR19SRVNFVF9DVEwo ZW5naW5lLT5tbWlvX2Jhc2UpLAo+IC0JCQkgICBfTUFTS0VEX0JJVF9ESVNBQkxFKFJFU0VUX0NU TF9SRVFVRVNUX1JFU0VUKSk7Cj4gKwkJZ2VuOF91bnJlcXVlc3RfZW5naW5lX3Jlc2V0KGVuZ2lu ZSk7Cj4gIAo+ICAJcmV0dXJuIC1FSU87Cj4gIH0KPiAtLSAKPiAxLjkuMQpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=