From: OGAWA Hirofumi Subject: Re: [PATCH take 2][RFC] fat: Save FAT root directory timestamps to volume label Date: Mon, 27 Jul 2009 20:47:29 +0900 Message-ID: <87ljmas5ym.fsf@devron.myhome.or.jp> References: <1248274841-3586-1-git-send-email-ext-jorg.2.schummer@nokia.com> <1248428635-26073-1-git-send-email-ext-jorg.2.schummer@nokia.com> <87fxclmhxy.fsf@devron.myhome.or.jp> <1248691635.4618.43.camel@jorg-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "linux-kernel\@vger.kernel.org" , "linux-fsdevel\@vger.kernel.org" To: =?iso-8859-1?Q?J=F6rg?= Schummer Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:54615 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbZG0Lrb (ORCPT ); Mon, 27 Jul 2009 07:47:31 -0400 In-Reply-To: <1248691635.4618.43.camel@jorg-desktop> (=?iso-8859-1?Q?=22J?= =?iso-8859-1?Q?=F6rg?= Schummer"'s message of "Mon, 27 Jul 2009 13:47:15 +0300") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: J=F6rg Schummer writes: > Hi, Hi, > If you don't want this patch.. There's probably good reasons not to t= ake > it, especially the amount-of-problem-solving-by-maintenance-cost rati= o > might be rather low. Also, the option is easy to add, but really hard to delete by backward compatible reason. This is why I'm so careful to it. BTW, the patch has several bugs. fat_get_label_entry() doesn't check IS_FREE(), is it right? fat_create_label_entry() doesn't initialize all timestamp in the case of msdos. spin_lock() usage is wrong. and more... >> Well, so, what is this for? If rootdir doesn't have timestamp, some = app >> is not working, or something? > > To be honest, the only app which I can think of here is some > backup-script which I wrote many years ago and which has not been in = use > anymore for a long time. (Maybe rsync or similar could also fail unde= r > some circumstances? Not sure.) > > So some backup / synchronisation apps might not work properly. But wh= o's > going to use FAT for sensitive, i.e. backup-worthy data anyway? The > answer is: People who use the same volume in many different machines, > some of which might be able to speak only FAT. Drawback: Just for the= se > people this patch might not be useful since none of those FAT machine= s > (except for the apple and possibly the penguin) support root dir > timestamps anyway. So whatever timestamps are found at backup-time, t= hey > cannot be trusted, because the volume might have been in use by stand= ard > FAT implementations. > > In summary: If you're not keen on integrating new features which woul= d > make Linux look good in the face of shiny Mac OS, there might not be > much reason to take it in. Unless we get zillions of people replying = now > with what wonderful things it would enable them to do.. ;-) Yes, we would really want to know whether people want to use this. Is there any info from Mac OS people? BTW, my thinking is, the option is why default is "rootts=3Dignore" if it's really good? Or 4 rootts=3D* options is really needed, and what is reason? Or if it's not good by some reasons, why is it added? ... Thanks. --=20 OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html