From: OGAWA Hirofumi Subject: Re: [PATCH 1/5] [BLOCK] Add 'discard' request handling Date: Thu, 07 Aug 2008 04:28:43 +0900 Message-ID: <87ljzaosd0.fsf@devron.myhome.or.jp> References: <488B7281.4020007@gmail.com> <20080726130200.f541e604.akpm@linux-foundation.org> <1217900716.3454.667.camel@pmac.infradead.org> <20080805114210.GW20055@kernel.dk> <1217953741.3454.784.camel@pmac.infradead.org> <1217957140.3454.800.camel@pmac.infradead.org> <1218014703.5111.35.camel@pmac.infradead.org> <877iauqfob.fsf@devron.myhome.or.jp> <1218046685.5111.124.camel@pmac.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jens Axboe , Andrew Morton , Ric Wheeler , linux-fsdevel@vger.kernel.org, gilad@codefidence.com To: David Woodhouse Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:39364 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015AbYHFT2r (ORCPT ); Wed, 6 Aug 2008 15:28:47 -0400 In-Reply-To: <1218046685.5111.124.camel@pmac.infradead.org> (David Woodhouse's message of "Wed, 06 Aug 2008 19:18:05 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: David Woodhouse writes: >> If fs merges contiguous blocks to one bio, bi_size will overflow. >> Will we have to limit (of the device?) and separate for the device? > > Or just let the device deal with it in multiple requests if it needs to? > I have no strong opinion. Ah, I see. >> Or how about to have #define for discard bio for BIO_RW_DISCARD users? > > Que? How about to add #define like BIO_MAX_SIZE of limit for one discard bio? Maybe, it is needed for BIO_RW_DISCARD users...? -- OGAWA Hirofumi