From: Marco Gerards <mgerards@xs4all.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20071223210936.GA27776@thorin> <20071224012818.GA22510@thorin>
	<20071224013530.GA22710@thorin> <4776DD49.7030406@nic.fi>
Mail-Copies-To: mgerards@xs4all.nl
Date: Wed, 23 Jan 2008 13:23:52 +0100
In-Reply-To: <4776DD49.7030406@nic.fi> (Vesa =?iso-8859-1?Q?J=E4=E4skel=E4?=
	=?iso-8859-1?Q?inen's?= message of "Sun,
	30 Dec 2007 01:50:33 +0200")
Message-ID: <87lk6gpw6f.fsf@xs4all.nl>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: gfxterm / grub_virtual_screen_setcolorstate()
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>

Vesa J=E4=E4skel=E4inen <chaac@nic.fi> writes:

> Robert Millan wrote:
>> On Mon, Dec 24, 2007 at 02:28:18AM +0100, Robert Millan wrote:
>>> New patch.  Corrects a minor mistake when filling the last colum in the
>>> menu.  Also, it doesn't change the colors on gfxterm since some reasjus=
tments
>>> were needed for that, and there's also a bug that makes it impossible to
>>> change colors on the fly with gfxterm/vbe (I'll write more on that late=
r).
>>=20
>> This patch (relative to previous one) basicaly makes it work with a big
>> ugly kludge (see "| 0xff000000" line).  The problem seems to be that alp=
ha
>> channel is set to 0 for all return values of grub_video_map_color() after
>> gfxterm initialization.  I checked the few places in the code where those
>> variables are zeroed, but to no avail.  I assume the problem is just they
>> haven't been initialised, but I just have no idea where they're supposed=
 to.
>>=20
>> Any clues?
>
> Ok... Your "fix" with OR'ing is not a good one as that makes an
> assumption about display mode settings. Idea of mapping colors is to get
> most optimal color settings for desired video mode. Nevertheless I think
> I know the problem and I get back to you shortly... now I sleep :)
>
> That zero alpha setting most likely comes from color table being
> specified. (or from video mode settings currently in use, eg. no
> alpha/reserved bits)

This was fixed already?

--
Marco