Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC022C433E2 for ; Wed, 22 Jul 2020 05:50:27 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85B9520771 for ; Wed, 22 Jul 2020 05:50:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="WkXHIEq+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B9520771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BBPh073n5zDqlr for ; Wed, 22 Jul 2020 15:50:24 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BBPcG3XdNzDqjR for ; Wed, 22 Jul 2020 15:47:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=WkXHIEq+; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4BBPcG12CDz9sR4; Wed, 22 Jul 2020 15:47:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1595396830; bh=3EpGqxGRwEaUDRN6AabSEZ8X+y0g9deDjj+pF+Rh6Lc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WkXHIEq+DxKmQBGY2WXUPfWESZhAKJyxvhQVyVC/b66jYIt+xec2QC8DlQWcaRgOz s75BygXyOL0Qloq2rO8afK9NraYho6y9VNib+CYESMp9l+YAOBnkb60JSlV/RlTh3d tpsMreD4Jvj2Z8sUy+oKhW8gC2UGM+ajLQmWK3E+/Tbk4hq1h6be5qo20gTU+9bhEn VuIrk9OdImPSTPlogTRcJq37VhU3Xounwa5AcovqQUAYuBptNpfyJ+XtHHsd/ADLxX Q0+m2dh9f0HgProf0c8CBIecIpDSJHr65P1MPW4/rKA5+M3Huy9/w57kUy5UVkN/c2 JgmltTrXuC2Hg== From: Michael Ellerman To: Jordan Niethe , linuxppc-dev Subject: Re: [PATCH 5/5] powerpc sstep: Add tests for Prefixed Add Immediate In-Reply-To: References: <20200525025923.19843-1-jniethe5@gmail.com> <20200525025923.19843-5-jniethe5@gmail.com> Date: Wed, 22 Jul 2020 15:47:07 +1000 Message-ID: <87mu3sqexw.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Popple , Balamuruhan S Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Jordan Niethe writes: > On Mon, May 25, 2020 at 1:00 PM Jordan Niethe wrote: >> >> Use the existing support for testing compute type instructions to test >> Prefixed Add Immediate (paddi). The R bit of the paddi instruction >> controls whether current instruction address is used. Add test cases for >> when R=1 and for R=0. paddi has a 34 bit immediate field formed by >> concatenating si0 and si1. Add tests for the extreme values of this >> field. >> >> Skip the paddi tests if ISA v3.1 is unsupported. >> >> Some of these test cases were added by Balamuruhan S. >> >> Signed-off-by: Jordan Niethe >> --- >> arch/powerpc/lib/test_emulate_step.c | 127 ++++++++++++++++++ >> .../lib/test_emulate_step_exec_instr.S | 1 + >> 2 files changed, 128 insertions(+) ... >> diff --git a/arch/powerpc/lib/test_emulate_step_exec_instr.S b/arch/powerpc/lib/test_emulate_step_exec_instr.S >> index 1580f34f4f4f..aef53ee77a43 100644 >> --- a/arch/powerpc/lib/test_emulate_step_exec_instr.S >> +++ b/arch/powerpc/lib/test_emulate_step_exec_instr.S >> @@ -81,6 +81,7 @@ _GLOBAL(exec_instr) >> >> /* Placeholder for the test instruction */ >> 1: nop >> + nop >> patch_site 1b patch__exec_instr >> >> /* >> -- >> 2.17.1 >> > > Because of the alignment requirements of prefixed instructions, the > noops to be patched need to be aligned. > mpe, want me to send a new version? No I'll just squash it in. > --- a/arch/powerpc/lib/test_emulate_step_exec_instr.S > +++ b/arch/powerpc/lib/test_emulate_step_exec_instr.S > @@ -80,6 +80,7 @@ _GLOBAL(exec_instr) > REST_NVGPRS(r31) > > /* Placeholder for the test instruction */ > +.align 6 I'll change it to .balign 64. > 1: nop > nop > patch_site 1b patch__exec_instr cheers