Received: from eggs.gnu.org ([209.51.188.92]:35642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDlS3-0005ek-DP for qemu-devel@nongnu.org; Tue, 09 Apr 2019 03:45:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDlS2-00012H-JA for qemu-devel@nongnu.org; Tue, 09 Apr 2019 03:45:51 -0400 From: Markus Armbruster References: <9409d9bf-c513-d82b-d438-9173fc582d7f@redhat.com> Date: Tue, 09 Apr 2019 09:45:45 +0200 In-Reply-To: <9409d9bf-c513-d82b-d438-9173fc582d7f@redhat.com> (Thomas Huth's message of "Tue, 9 Apr 2019 08:13:33 +0200") Message-ID: <87mukzei52.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Stephen Checkoway , qemu-devel@nongnu.org, Kevin Wolf , Stephen Checkoway , qemu-block@nongnu.org, Laurent Vivier , Max Reitz , Paolo Bonzini Thomas Huth writes: > We'd like to get rid of global_qtest in the long run (since it is > causing trouble for tests that run multiple instances of QEMU in > parallel, e.g. migration tests)... so if it is feasible, please don't > use it in new code anymore. Try to use a local variable in the function > that call qtest_initf() and pass the test state around via a parameter > to the functions that need it. Twenty tests still use @global_qtest Either we're serious about getting rid of @global_qtest. Then we should just do it. Or we're not. Then we shouldn't ask contributors to do extra work.