From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06 Date: Sat, 08 Sep 2018 16:12:23 +0200 Message-ID: <87musst6wo.fsf@miraculix.mork.no> References: <20180908115048.12667-1-kristian.evensen@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org To: Kristian Evensen Return-path: Received: from canardo.mork.no ([148.122.252.1]:56259 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726498AbeIHS6V (ORCPT ); Sat, 8 Sep 2018 14:58:21 -0400 In-Reply-To: <20180908115048.12667-1-kristian.evensen@gmail.com> (Kristian Evensen's message of "Sat, 8 Sep 2018 13:50:48 +0200") Sender: netdev-owner@vger.kernel.org List-ID: Kristian Evensen writes: > Quectel EP06 (and EM06/EG06) supports dynamic configuration of USB > interfaces, without the device changing VID/PID or configuration number. > When the configuration is updated and interfaces are added/removed, the > interface numbers change. This means that the current code for matching > EP06 does not work. That's annoying, but hardly surprising. They obviously try to make life as hard as possible for the drivers. I wonder what the Windows drivers do here, if there are any? Or are these modules only used in embedded Linux devices? > This patch removes the current EP06 interface number match, and replaces > it with a match on class, subclass and protocol. Unfortunately, matching > on those three alone is not enough, as the diag interface exports the > same values as QMI. The other serial interfaces + adb export different > values and do not match. > > The diag interface only has two endpoints, while the QMI interface has > three. I have therefore added a check for number of interfaces, and we > ignore the interface if the number of endpoints equals two. Could this break if more/other functions are enabled? Are you sure there can't be any other type of serial function with 3 endpoints and ff/ff/ff? Well, I guess no one knows for sure... And this is more than good enough until it breaks. Thanks for solving the puzzle. Looks good to me. Acked-by: Bj=C3=B8rn Mork