From: Eric Anholt Subject: Re: [PATCH] drm/vc4: Move IRQ enable to PM path Date: Wed, 03 Jan 2018 16:28:12 -0800 Message-ID: <87mv1uv55v.fsf@anholt.net> References: <1514563543-32511-1-git-send-email-stschake@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1174845612==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 1172389FC9 for ; Thu, 4 Jan 2018 00:28:19 +0000 (UTC) In-Reply-To: <1514563543-32511-1-git-send-email-stschake@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org, Stefan Schake List-Id: dri-devel@lists.freedesktop.org --===============1174845612== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Stefan Schake writes: > We were calling enable_irq on bind, where it was already enabled previously > by the IRQ helper. Additionally, dev->irq is not set correctly until after > postinstall and so was always zero here, triggering a warning in 4.15. > Fix both by moving the enable to the power management resume path, where we > know there was a previous disable invocation during suspend. > > Fixes: 253696ccd613 ("drm/vc4: Account for interrupts in flight") > Signed-off-by: Stefan Schake > --- > I tested replacing the enable/disable dance with just synchronize_irq, > but that only made the original kernel OOPS more sporadic. Reviewed and applied. Thanks! Somewhere on the infinite TODO list is to stop using the DRM IRQ helpers and just install our IRQ handler on our own, which I think would have avoided this trouble. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlpNdRwACgkQtdYpNtH8 nuj80w/9Fh7GmSgMkWdYnx6tHNyudYnUi38HzyspuU61+U44kuYo3VNlV4K+pJXx NwatRPqYGCYvbVFRbnkZ3OYzxz/Te9P4J1RVmkZfYj7CLyw013fx6S6xDxkWVqvN Wq+J4kVi2dqmeM5pYoSnfvdHcsZfmiP8Afy7zPosu4bS4289IZQUiDU5aVILG2+L JP21HPkv1RYosG6sDgexS8/TLUzbMKpfGVFi9RL26eBPux88BQ3Odcw/8aiNj8wh HgEayohITE8UiHriea0vuYitiLVk3mgFgUtSauJKKKK8jBWfAYV27fS/wPjObdls dLr+QauFA6+3YWr2eDpO9tz+BF0+ONbtCZYulsRZ7CiE9gtanS1GQJahlbxUpUkQ aQc4UJfSdZZQ7Onmzf1ocNQn6dIzgepBg58xBGHGtGnjIs6RXj9B/yLtDnNjDBH6 lheLTEiewpP0IpDs8bejEzanMvWb4T8ptnY8cTvDC0GlcvIV87NPQnwdLgGBdPUI v8/zObrNSL6PlbG7I0cwBKvrVCzhVGTXugo6Bwgvso1w93UGi0Iq3G01JL9x+tMw SGbxtXWq7+5iCMw65E3eNH+SUqTV1fApN6n7sj6tw/CPv2RWDgfep298Bcrex3Yr NMlWSr7QSU2CrZ3nX2OPIZuB8ViT60IS2rfxbYn2miaASG3CJEU= =TmSg -----END PGP SIGNATURE----- --=-=-=-- --===============1174845612== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1174845612==--