From: Gabriel Krisman Bertazi Subject: Re: [PATCH i-g-t 3/7] lib: Stop igt_get_all_cairo_formats memory leak Date: Tue, 25 Apr 2017 14:43:13 -0300 Message-ID: <87mvb4bcy6.fsf@dilma.collabora.co.uk> References: <1493138713-2319-1-git-send-email-brian.starkey@arm.com> <1493138713-2319-4-git-send-email-brian.starkey@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 473D86E5B7 for ; Tue, 25 Apr 2017 17:43:19 +0000 (UTC) In-Reply-To: <1493138713-2319-4-git-send-email-brian.starkey@arm.com> (Brian Starkey's message of "Tue, 25 Apr 2017 17:45:09 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Brian Starkey Cc: intel-gfx@lists.freedesktop.org, liviu.dudau@arm.com List-Id: intel-gfx@lists.freedesktop.org QnJpYW4gU3RhcmtleSA8YnJpYW4uc3RhcmtleUBhcm0uY29tPiB3cml0ZXM6Cgo+IGlndF9nZXRf YWxsX2NhaXJvX2Zvcm1hdHMoKSBhbGxvY2F0ZXMgdGhlIGZvcm1hdCBsaXN0IG9uIHRoZSBoZWFw LCBidXQKPiByZXR1cm5zIGl0IGluIGEgY29uc3QgcG9pbnRlci4gQ2hhbmdlIHRoaXMgc28gdGhh dCBjYWxsZXJzIGNhbiBmcmVlIHRoZQo+IGFycmF5IHdpdGhvdXQgYSB3YXJuaW5nLCBhbmQgZnJl ZSB0aGUgYXJyYXkgaW4gYWxsIGNhbGxlcnMuCj4KPiBTaWduZWQtb2ZmLWJ5OiBCcmlhbiBTdGFy a2V5IDxicmlhbi5zdGFya2V5QGFybS5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfZmIuYyAgICAgICB8 ICAgIDQgKysrLQo+ICBsaWIvaWd0X2ZiLmggICAgICAgfCAgICAyICstCj4gIHRlc3RzL2ttc19h dG9taWMuYyB8ICAgIDMgKystCj4gIHRlc3RzL2ttc19yZW5kZXIuYyB8ICAgIDQgKysrLQo+ICA0 IGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0X2ZiLmMKPiBpbmRleCBkMmI3ZTllMzY2MDYu LmI5NThjOTcwOTczYiAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2ZiLmMKPiArKysgYi9saWIvaWd0 X2ZiLmMKPiBAQCAtMTI3Nyw4ICsxMjc3LDEwIEBAIGNvbnN0IGNoYXIgKmlndF9mb3JtYXRfc3Ry KHVpbnQzMl90IGRybV9mb3JtYXQpCj4gICAqCj4gICAqIFRoaXMgZnVuY3Rpb25zIHJldHVybnMg YW4gYXJyYXkgb2YgYWxsIHRoZSBkcm0gZm91cmNjIGNvZGVzIHN1cHBvcnRlZCBieQo+ICAgKiBj YWlybyBhbmQgdGhpcyBsaWJyYXJ5Lgo+ICsgKgo+ICsgKiBUaGUgYXJyYXkgc2hvdWxkIGJlIGZy ZWVkIGJ5IHRoZSBjYWxsZXIuCj4gICAqLwo+IC12b2lkIGlndF9nZXRfYWxsX2NhaXJvX2Zvcm1h dHMoY29uc3QgdWludDMyX3QgKipmb3JtYXRzLCBpbnQgKmZvcm1hdF9jb3VudCkKPiArdm9pZCBp Z3RfZ2V0X2FsbF9jYWlyb19mb3JtYXRzKHVpbnQzMl90ICoqZm9ybWF0cywgaW50ICpmb3JtYXRf Y291bnQpCj4gIHsKPiAgCXN0YXRpYyB1aW50MzJfdCAqZHJtX2Zvcm1hdHM7Cj4gIAlzdGF0aWMg aW50IG5fZm9ybWF0czsKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5oIGIvbGliL2lndF9mYi5o Cj4gaW5kZXggNGE2ODBjZWZiMTZkLi5lMTI0OTEwMzY3YTMgMTAwNjQ0Cj4gLS0tIGEvbGliL2ln dF9mYi5oCj4gKysrIGIvbGliL2lndF9mYi5oCj4gQEAgLTE1NCw3ICsxNTQsNyBAQCBpbnQgaWd0 X2NhaXJvX3ByaW50Zl9saW5lKGNhaXJvX3QgKmNyLCBlbnVtIGlndF90ZXh0X2FsaWduIGFsaWdu LAo+ICB1aW50MzJfdCBpZ3RfYnBwX2RlcHRoX3RvX2RybV9mb3JtYXQoaW50IGJwcCwgaW50IGRl cHRoKTsKPiAgdWludDMyX3QgaWd0X2RybV9mb3JtYXRfdG9fYnBwKHVpbnQzMl90IGRybV9mb3Jt YXQpOwo+ICBjb25zdCBjaGFyICppZ3RfZm9ybWF0X3N0cih1aW50MzJfdCBkcm1fZm9ybWF0KTsK PiAtdm9pZCBpZ3RfZ2V0X2FsbF9jYWlyb19mb3JtYXRzKGNvbnN0IHVpbnQzMl90ICoqZm9ybWF0 cywgaW50ICpmb3JtYXRfY291bnQpOwo+ICt2b2lkIGlndF9nZXRfYWxsX2NhaXJvX2Zvcm1hdHMo dWludDMyX3QgKipmb3JtYXRzLCBpbnQgKmZvcm1hdF9jb3VudCk7Cj4gIAo+ICAjZW5kaWYgLyog X19JR1RfRkJfSF9fICovCj4gIAo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfYXRvbWljLmMgYi90 ZXN0cy9rbXNfYXRvbWljLmMKPiBpbmRleCA2Mzc1ZmVkZTcxNzkuLjljMDNmNmUyMWViYiAxMDA2 NDQKPiAtLS0gYS90ZXN0cy9rbXNfYXRvbWljLmMKPiArKysgYi90ZXN0cy9rbXNfYXRvbWljLmMK PiBAQCAtODA3LDcgKzgwNyw3IEBAIHN0YXRpYyB2b2lkIGF0b21pY19zdGF0ZV9mcmVlKHN0cnVj dCBrbXNfYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgc3RhdGljIHVpbnQzMl90IHBsYW5lX2dldF9p Z3RfZm9ybWF0KHN0cnVjdCBrbXNfYXRvbWljX3BsYW5lX3N0YXRlICpwbGFuZSkKPiAgewo+ICAJ ZHJtTW9kZVBsYW5lUHRyIHBsYW5lX2ttczsKPiAtCWNvbnN0IHVpbnQzMl90ICppZ3RfZm9ybWF0 czsKPiArCXVpbnQzMl90ICppZ3RfZm9ybWF0czsKPiAgCXVpbnQzMl90IHJldCA9IDA7Cj4gIAlp bnQgbnVtX2lndF9mb3JtYXRzOwo+ICAJaW50IGk7Cj4gQEAgLTgyNyw2ICs4MjcsNyBAQCBzdGF0 aWMgdWludDMyX3QgcGxhbmVfZ2V0X2lndF9mb3JtYXQoc3RydWN0IGttc19hdG9taWNfcGxhbmVf c3RhdGUgKnBsYW5lKQo+ICAJCX0KPiAgCX0KPiAgCj4gKwlmcmVlKGlndF9mb3JtYXRzKTsKPiAg CWRybU1vZGVGcmVlUGxhbmUocGxhbmVfa21zKTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiBkaWZm IC0tZ2l0IGEvdGVzdHMva21zX3JlbmRlci5jIGIvdGVzdHMva21zX3JlbmRlci5jCj4gaW5kZXgg ZmQzM2RmYjdjYWZlLi5iYzJmZmM3NTBjNjcgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMva21zX3JlbmRl ci5jCj4gKysrIGIvdGVzdHMva21zX3JlbmRlci5jCj4gQEAgLTE3Niw3ICsxNzYsNyBAQCBzdGF0 aWMgdm9pZCB0ZXN0X2Nvbm5lY3Rvcihjb25zdCBjaGFyICp0ZXN0X25hbWUsCj4gIAkJCSAgIHN0 cnVjdCBrbXN0ZXN0X2Nvbm5lY3Rvcl9jb25maWcgKmNjb25mLAo+ICAJCQkgICBlbnVtIHRlc3Rf ZmxhZ3MgZmxhZ3MpCj4gIHsKPiAtCWNvbnN0IHVpbnQzMl90ICpmb3JtYXRzOwo+ICsJdWludDMy X3QgKmZvcm1hdHM7Cj4gIAlpbnQgZm9ybWF0X2NvdW50Owo+ICAJaW50IGk7Cj4gIAo+IEBAIC0x OTMsNiArMTkzLDggQEAgc3RhdGljIHZvaWQgdGVzdF9jb25uZWN0b3IoY29uc3QgY2hhciAqdGVz dF9uYW1lLAo+ICAJCQkgICAgY2NvbmYsICZjY29uZi0+Y29ubmVjdG9yLT5tb2Rlc1swXSwKPiAg CQkJICAgIGZvcm1hdHNbaV0sIGZsYWdzKTsKPiAgCX0KPiArCj4gKwlmcmVlKGZvcm1hdHMpOwoK SGksCgpBc3N1bWluZyBJJ20gbm90IG1pc3NpbmcgYW55dGhpbmcsIEkgdGhpbmsgaWYgeW91IGZy ZWUgZm9ybWF0cyBoZXJlLCB0aGUKc3RhdGljIHZhcmlhYmxlIGluIGlndF9nZXRfYWxsX2NhaXJv X2Zvcm1hdHMoKSB3aWxsIHBvaW50IHRvIGdhcmJhZ2UgYW5kCmZ1cnRoZXIgY2FsbHMgdG8gdGhh dCBmdW5jdGlvbiB3aWxsIHJldHVybiB1bmluaXRpYWxpemVkIG1lbW9yeS4KCgoKLS0gCkdhYnJp ZWwgS3Jpc21hbiBCZXJ0YXppCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=