Received: from eggs.gnu.org ([2001:4830:134:3::10]:59893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQWpa-0005Nl-Vm for qemu-devel@nongnu.org; Tue, 02 Feb 2016 04:01:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQWpW-0006X8-VH for qemu-devel@nongnu.org; Tue, 02 Feb 2016 04:01:02 -0500 From: Markus Armbruster References: <1454075341-13658-1-git-send-email-eblake@redhat.com> <1454075341-13658-24-git-send-email-eblake@redhat.com> <87oac060k9.fsf@blackfin.pond.sub.org> <56AFE6D8.1050500@redhat.com> Date: Tue, 02 Feb 2016 10:00:55 +0100 In-Reply-To: <56AFE6D8.1050500@redhat.com> (Eric Blake's message of "Mon, 1 Feb 2016 16:14:32 -0700") Message-ID: <87mvrjsczc.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Alexander Graf , qemu-devel@nongnu.org, Michael Roth , "open list:sPAPR" , marcandre.lureau@redhat.com, David Gibson Eric Blake writes: > On 02/01/2016 06:07 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> No backend was setting an error when ending an implicit struct, >>> or when iterating a list. >> >> Perhaps "when ending the visit of a list or implicit struct, or when >> moving to the next list node" would be more precise. If you like it, I >> can do that on commit. Done. >>> Make the callers a bit easier to follow >>> by making this a part of the contract, and removing the errp >>> argument - callers can then unconditionally end an object as >>> part of cleanup without having to think about whether a second >>> error is dominated by a first, because there is no second error. >>> >>> A later patch will then tackle the larger task of splitting >>> visit_end_struct(), which can indeed set an error (and that >>> cleanup will also have the side-effect of removing the use of >>> error_abort added here). > > Oh, while you're touching this up, the last half of this sentence is now > stale (since the addition of &error_abort was split out into 22/25 > instead); I'd just delete the entire parenthetical, ending with "indeed > set an error." Done.