Received: from eggs.gnu.org ([2001:4830:134:3::10]:40122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9rkS-0001fx-1A for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:54:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9rkN-00041r-RC for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:54:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9rkN-00041i-Lk for qemu-devel@nongnu.org; Fri, 18 Dec 2015 04:54:47 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 0D870693DD for ; Fri, 18 Dec 2015 09:54:46 +0000 (UTC) From: Markus Armbruster References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-18-git-send-email-armbru@redhat.com> <5673226A.6050205@redhat.com> Date: Fri, 18 Dec 2015 10:54:44 +0100 In-Reply-To: <5673226A.6050205@redhat.com> (Eric Blake's message of "Thu, 17 Dec 2015 14:00:26 -0700") Message-ID: <87mvt8hyjf.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 17/23] vmdk: Clean up control flow in vmdk_parse_extents() a bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Fam Zheng , qemu-devel@nongnu.org Eric Blake writes: > On 12/17/2015 09:49 AM, Markus Armbruster wrote: >> Cc: Fam Zheng >> Signed-off-by: Markus Armbruster >> --- >> block/vmdk.c | 28 +++++++++++++++------------- >> 1 file changed, 15 insertions(+), 13 deletions(-) > > Could have mentioned what the change was: factoring out a common > next_line() helper to let you drop an end-of-loop label. Adding: Factor out loop stepping to turn a while-loop with goto into a for-loop with continue. > Reviewed-by: Eric Blake Thanks!