Received: from eggs.gnu.org ([2001:4830:134:3::10]:41692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3ptl-0008Dx-Tl for qemu-devel@nongnu.org; Tue, 01 Dec 2015 13:43:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3pth-0001Hf-TT for qemu-devel@nongnu.org; Tue, 01 Dec 2015 13:43:33 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:50463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3pth-0001HO-KT for qemu-devel@nongnu.org; Tue, 01 Dec 2015 13:43:29 -0500 From: OGAWA Hirofumi References: <87r3j95407.fsf@mail.parknet.co.jp> <1448979081.26005.10.camel@redhat.com> Date: Wed, 02 Dec 2015 03:43:23 +0900 In-Reply-To: <1448979081.26005.10.camel@redhat.com> (Gerd Hoffmann's message of "Tue, 01 Dec 2015 15:11:21 +0100") Message-ID: <87mvtu57sk.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] ui/curses: Fix color attribute of monitor for curses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: >> static const pixman_color_t color_table_rgb[2][8] = { >> { /* dark */ >> - QEMU_RGB(0x00, 0x00, 0x00), /* black */ >> - QEMU_RGB(0xaa, 0x00, 0x00), /* red */ >> - QEMU_RGB(0x00, 0xaa, 0x00), /* green */ >> - QEMU_RGB(0xaa, 0xaa, 0x00), /* yellow */ >> - QEMU_RGB(0x00, 0x00, 0xaa), /* blue */ >> - QEMU_RGB(0xaa, 0x00, 0xaa), /* magenta */ >> - QEMU_RGB(0x00, 0xaa, 0xaa), /* cyan */ >> - QEMU_RGB(0xaa, 0xaa, 0xaa), /* white */ >> + [QEMU_COLOR_BLACK] = QEMU_RGB(0x00, 0x00, 0x00), /* black */ >> + [QEMU_COLOR_BLUE] = QEMU_RGB(0x00, 0x00, 0xaa), /* blue */ >> + [QEMU_COLOR_GREEN] = QEMU_RGB(0x00, 0xaa, 0x00), /* green */ >> + [QEMU_COLOR_CYAN] = QEMU_RGB(0x00, 0xaa, 0xaa), /* cyan */ >> + [QEMU_COLOR_RED] = QEMU_RGB(0xaa, 0x00, 0x00), /* red */ >> + [QEMU_COLOR_MAGENTA] = QEMU_RGB(0xaa, 0x00, 0xaa), /* magenta */ >> + [QEMU_COLOR_YELLOW] = QEMU_RGB(0xaa, 0xaa, 0x00), /* yellow */ >> + [QEMU_COLOR_WHITE] = QEMU_RGB(0xaa, 0xaa, 0xaa), /* white */ > > The color comments are kind of redundant now ... OK. -- OGAWA Hirofumi