From: Kalle Valo Subject: Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree Date: Mon, 30 Nov 2015 11:05:52 +0200 Message-ID: <87mvtvluvj.fsf@kamboji.qca.qualcomm.com> References: <1444972259-24260-1-git-send-email-motobud@gmail.com> <1448774038-26984-1-git-send-email-motobud@gmail.com> <87zixvlvp8.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: , , , To: Brent Taylor Return-path: In-Reply-To: <87zixvlvp8.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Mon, 30 Nov 2015 10:48:03 +0200") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Kalle Valo writes: > Brent Taylor writes: > >> Signed-off-by: Brent Taylor >> >> ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree >> --- >> Changes v1 -> v2: >> - simplify memory allocation >> - use kvfree > > Why? The commit log should _always_ answer that. Are you fixing a bug > (what bug exactly?), is this just cleanup or what? > > And the commit log is wrongly formatted anyway, the Signed-off-by line > should be the last and there should be no "ath6kl:" string in the commit > log (just in the title). Use 'git log' to find examples. Fixing netdev address (kenrel -> kernel) -- Kalle Valo