Received: from eggs.gnu.org ([2001:4830:134:3::10]:50541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zz7QC-0003hJ-Rh for qemu-devel@nongnu.org; Wed, 18 Nov 2015 13:25:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zz7Q7-0002bT-S8 for qemu-devel@nongnu.org; Wed, 18 Nov 2015 13:25:32 -0500 From: Markus Armbruster References: <1447836791-369-1-git-send-email-eblake@redhat.com> <1447836791-369-30-git-send-email-eblake@redhat.com> Date: Wed, 18 Nov 2015 19:25:18 +0100 In-Reply-To: <1447836791-369-30-git-send-email-eblake@redhat.com> (Eric Blake's message of "Wed, 18 Nov 2015 01:53:04 -0700") Message-ID: <87mvubjhbl.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v12 29/36] qobject: Rename qtype_code to QType List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Luiz Capitulino , qemu-devel@nongnu.org, "open list:Block layer core" , Michael Roth Eric Blake writes: > The name QType is more in line with our conventions for qapi > types, and matches the fact that each enum member has a prefix > of QTYPE_. > > Signed-off-by: Eric Blake At this point, the connection to QAPI is unobvious. You can either point to CODING_STYLE, which ask for type names in CamelCase, or to the next patch. Patch looks good.