Received: from eggs.gnu.org ([2001:4830:134:3::10]:58833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YODkR-0005zG-5a for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:09:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YODkN-0000Oy-Qc for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:09:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YODkN-0000Oq-J7 for qemu-devel@nongnu.org; Wed, 18 Feb 2015 18:09:35 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1IN9YX3019146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 18 Feb 2015 18:09:34 -0500 From: Juan Quintela In-Reply-To: <1424283712-476-1-git-send-email-armbru@redhat.com> (Markus Armbruster's message of "Wed, 18 Feb 2015 19:21:52 +0100") References: <1424283712-476-1-git-send-email-armbru@redhat.com> Date: Thu, 19 Feb 2015 00:09:31 +0100 Message-ID: <87mw4a3jh0.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] migration: Avoid qerror_report_err() outside QMP command handlers Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: amit.shah@redhat.com, qemu-devel@nongnu.org Markus Armbruster wrote: > qerror_report_err() is a transitional interface to help with > converting existing monitor commands to QMP. It should not be used > elsewhere. Replace by error_report_err() in > process_incoming_migration_co(). I trust you & eric Included, thanks. > > Signed-off-by: Markus Armbruster > --- > Based on > [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err() > > migration/migration.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index b3adbc6..6a5e3f9 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -106,8 +106,7 @@ static void process_incoming_migration_co(void *opaque) > /* Make sure all file formats flush their mutable metadata */ > bdrv_invalidate_cache_all(&local_err); > if (local_err) { > - qerror_report_err(local_err); > - error_free(local_err); > + error_report_err(local_err); > exit(EXIT_FAILURE); > }